Cannot separate SObject metadata (fields, validationRules) into modules inside single package (sometimes) #2230
Description
Summary
When there are multiple folders for the same object, it is important in which of them the object's object-meta.xml file is placed. If it is in the first one (alphabetically), then all is well. If it is not though, then the below error appears during deployment. And the reason seems to be that the main object metadata is then "lost"
"Must specify a non-empty label for the CustomObject"
When using force source convert instead of deploy resuts show that generated CustomObject__c.object is missing the object level attributes when CustomObject__c.object-meta.xml was not placed in the alphabetically first module/folder. All fields or validation rules are present regardless of their placement. On the other hand when CustomObject__c.object-meta.xml is in the first one, all fields and validation rules as well as object level attributes are there and all is well.
More detailed description in this Stack Exchange question if needed
It seems somewhat similar to this existing issue. Though it's about the same xml file existing twice, while this is separate sub-parts of the object metadata coming from different folders (no duplication)
Steps To Reproduce
Reproduce issue [here](https://github.com/packocz/SObjectSeparation. Single package defined in sfdx-project.json)
3 different sub-modules inside this package. Each contains the same objects/CustomObject__c/ folder, one meant to define the object, 2 feature sub-modules add fields/validationRules. This only works if CustomObject__c.object-meta.xml is in the alphabetically first folder.
- Clone Repository above
- Create scratch org (or any pre-athorised org is fine)
- Deploy full
force-apppacakge into any (empty) org usingsfdx force source deploy --sourcepath force-app --target-org XXXXX --checkonly>> produces error - Move
CustomObject__c.object-meta.xmlfromforce-app/main/default/objects/CustomObject__c/intoforce-app/aa-package/objects/CustomObject__c/ - Deploy full
force-apppacakge into any (empty) org usingsfdx force source deploy --sourcepath force-app --target-org XXXXX --checkonly>> works fine
Expected result
Package deploys with all expected custom Fields and Validation Rules
Actual result
Deploy fails with missing attributes that are actually defined in the source
System Information
zhs terminal
Mac OS 13.4
{
"cliVersion": "sfdx-cli/7.205.6",
"architecture": "darwin-x64",
"nodeVersion": "node-v18.15.0",
"osVersion": "Darwin 22.5.0",
"shell": "zsh",
"rootPath": "/Users/ales.remta/.local/share/sfdx/client/7.205.6-dfc6717",
"pluginVersions": [
"@dxatscale/sfpowerscripts 21.1.0 (user)",
"@oclif/plugin-autocomplete 2.3.0 (core)",
"@oclif/plugin-commands 2.2.15 (core)",
"@oclif/plugin-help 5.2.9 (core)",
"@oclif/plugin-not-found 2.3.24 (core)",
"@oclif/plugin-plugins 3.1.2 (core)",
"@oclif/plugin-search 0.0.17 (core)",
"@oclif/plugin-update 3.1.17 (core)",
"@oclif/plugin-version 1.3.4 (core)",
"@oclif/plugin-warn-if-update-available 2.0.37 (core)",
"@oclif/plugin-which 2.2.22 (core)",
"@salesforce/lwc-dev-server 2.11.0 (user)",
"apex 2.3.3 (core)",
"auth 2.8.1 (core)",
"community 2.3.1 (core)",
"custom-metadata 2.1.25 (core)",
"data 2.3.22 (core)",
"deploy-retrieve 1.11.7 (core)",
"info 2.6.19 (core)",
"limits 2.3.18 (core)",
"org 2.9.8 (core)",
"packaging 1.19.0 (core)",
"schema 2.3.12 (core)",
"settings 1.4.11 (core)",
"signups 1.4.21 (core)",
"source 2.10.14 (core)",
"telemetry 2.2.0 (core)",
"templates 55.4.20 (core)",
"trust 2.4.20 (core)",
"user 2.3.17 (core)",
"@salesforce/sfdx-plugin-lwc-test 1.0.2 (user)",
"@salesforce/sfdx-scanner 3.13.0 (user)",
"sfdx-cli 7.205.6 (core)",
"sfdx-git-delta 5.22.0 (user)",
"texei-sfdx-plugin 1.17.3 (user)"
]
}