Sm/return-ignores #553
Closed
Sm/return-ignores #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Jan 18, 2022
Member
WillieRuemmele
left a comment
WillieRuemmele
left a comment
There was a problem hiding this comment.
I was a little worried this could have unintended consequences at first, but it's only filling out the forceIgnoredPaths list which should be safe enough 👍
shetzel
approved these changes
Jan 18, 2022
Contributor
Author
|
abandoning because SDR doesn't crawl inside bundles for things like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
make a more complete
forceIgnoredPathsWhat issues does this PR fix or reference?
@W-10449080@
Functionality Before
forceignored from metadataResolver or componentSet would only list resolved components that were ignored. Commonly ignored files like
lwc/jsconfig.jsonwere not listed even though they were ignored because they weren't being recognized as components.