Skip to content

ignored:list #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WillieRuemmele merged 16 commits into from
Jan 20, 2022
Merged

ignored:list #391

WillieRuemmele merged 16 commits into from
Jan 20, 2022

Conversation

@mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 18, 2022 •
edited
Loading

What does this PR do?

the last of the source commands from toolbelt

What issues does this PR fix or reference?

@W-10449080@

WillieRuemmele
WillieRuemmele reviewed Jan 18, 2022
View reviewed changes
test/nuts/ignored_list.nut.ts
import { AuthStrategy } from '@salesforce/cli-plugins-testkit/lib/hubAuth';
import { SourceIgnoredResults } from '../../src/commands/force/source/ignored/list';

describe('force:source:ignored:list', () => {
Copy link
Contributor

@WillieRuemmele WillieRuemmele Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we test the "no ignored files" possibility?

messages/ignored_list.json
"flags": {
"sourcepath": "file or directory of files that the command checks for foreceignored files"
},
"invalidSourcePath": "File or directory '%s' doesn't exist in your project. Specify one that exists and rerun the command."
Copy link
Contributor

@WillieRuemmele WillieRuemmele Jan 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this message used?

Copy link
Contributor Author

@mshanemc mshanemc Jan 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call...not anymore. SDR is gonna handle that

@WillieRuemmele
Copy link
Contributor

WillieRuemmele commented Jan 19, 2022 •
edited
Loading

QA:
with forcedotcom/source-deploy-retrieve#553 linked on a stock dreamhouse-lwc project

❌ force:source:ignored:list previously included all of the __tests__ directories, now it doesn't show them
✅ : no results found
✅ : JSON structure the same, but missing files from first point above
✅ : handles nested .forceignores as long as -p points to the parent directory of the nested .forecignore (toolbelt didn't recognize any new .forceignores)
❓ : didn't read nested .forceignore it discovered (same as toolbelt)

@WillieRuemmele
Copy link
Contributor

WillieRuemmele commented Jan 20, 2022

QA:
✅ : includes __tests__ correctly
✅ : JSON
✅ : no results
✅ : -p behavior
✅ : -p <file doesn't exist> errors correctly

@WillieRuemmele WillieRuemmele merged commit 232bca9 into main Jan 20, 2022
@WillieRuemmele WillieRuemmele deleted the sm/ignored branch January 20, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele left review comments

@shetzel shetzel shetzel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mshanemc @WillieRuemmele @shetzel