[15 min fix] Fixed flaky E2E test for comments#13380
Merged
nickytonline merged 3 commits intomasterfrom Apr 14, 2021
Merged
Conversation
nickytonline
added
the
merge by any core
nickytonline
changed the title
rhymes
approved these changes
Apr 14, 2021
pr-triage
bot
added
PR: partially-approved
aitchiss
approved these changes
Apr 14, 2021
Contributor
aitchiss
left a comment
aitchiss
left a comment
There was a problem hiding this comment.
This looks good to me - thanks for looking into it!
…fix-revert-changes-editor-feature
pr-triage
bot
added
PR: unreviewed
djuber
approved these changes
Apr 14, 2021
|
|
||
| // TODO: Flaky spec | ||
| xit('should reply to a comment with user mention autocomplete', () => { | ||
| it('should reply to a comment with user mention autocomplete', () => { |
Contributor
There was a problem hiding this comment.
Well, that's all you had to say!
pr-triage
bot
added
PR: partially-approved
Contributor
Author
|
I ran this 20 times locally and all was good and I've rerun the build node 4 (front-end tests/E2E test) 3 times, so feeling pretty confident that this flaky test is squashed. |
nickytonline
deleted the
nickytonline/15-min-fix-e2e-flaky-test-for-comments
branch
pr-triage
bot
added
PR: merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Reenabled and fix a flaky E2E test for comments.
Related Tickets & Documents
#13187
QA Instructions, Screenshots, Recordings
N/A. Just reenabling a test.
UI accessibility concerns?
N/A. Just reenabling a test.
Added tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Admin Guide, or
Storybook (for Crayons components)
or in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?