[15 min fix] Used the all browser supported document.body.#13397
Merged
nickytonline merged 2 commits intomasterfrom Apr 14, 2021
Merged
[15 min fix] Used the all browser supported document.body.#13397nickytonline merged 2 commits intomasterfrom
nickytonline merged 2 commits intomasterfrom
Conversation
nickytonline
added
the
tech: javascript
nickytonline
requested review from
a team,
fdocr,
jacobherrington,
juliannatetreault and
msarit
and removed request for
a team
nickytonline
changed the title
rhymes
approved these changes
Apr 14, 2021
pr-triage
bot
added
PR: partially-approved
…-fix-use-document-dot-body
pr-triage
bot
added
PR: unreviewed
nickytonline
added
the
merge by any core
vaidehijoshi
approved these changes
Apr 14, 2021
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Tiny refactor I came across while investigating another issue.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
N/A
UI accessibility concerns?
N/A
Added tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Admin Guide, or
Storybook (for Crayons components)
or in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?