Refactor method in internal controller#7655
Merged
rhymes merged 1 commit intoforem:masterfrom May 7, 2020
luchiago:luchiago/refactor-internal-config-controller-3739
Merged
Refactor method in internal controller#7655rhymes merged 1 commit intoforem:masterfrom luchiago:luchiago/refactor-internal-config-controller-3739
rhymes merged 1 commit intoforem:masterfrom
luchiago:luchiago/refactor-internal-config-controller-3739
Conversation
pr-triage
Bot
added
PR: reviewed-approved
rhymes
approved these changes
May 7, 2020
pr-triage
Bot
added
PR: merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
#3739
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?