Skip to content

Fix host-side Git commit identity - #277

Merged
eshulman2 merged 1 commit into
mainfrom
fix/host-git-commit-identity
Aug 7, 2026
Merged

Fix host-side Git commit identity#277
eshulman2 merged 1 commit into
mainfrom
fix/host-git-commit-identity

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • configure the Git committer identity per host-side commit using the existing Forge Git settings
  • use the configured Git email for the explicit author identity
  • add a regression test that commits with an empty global Git configuration and verifies author and committer metadata

Root cause

AISOS-2385 exposed that GitOperations.commit() supplied --author but relied on the worker service account's global Git configuration for the committer. On workers without that configuration, Git failed with Committer identity unknown, leaving dirty workspaces and triggering workspace recovery failures.

Testing

  • uv run ruff check src/forge/workspace/git_ops.py tests/unit/workspace/test_git_ops_commit.py
  • uv run pytest tests/unit/workspace/test_git_ops_commit.py tests/unit/workspace/test_git_ops_sync.py tests/unit/workspace/test_git_ops_redaction.py (6 passed)

@eshulman2
eshulman2 merged commit 7c74541 into main Aug 7, 2026
6 checks passed
@eshulman2
eshulman2 deleted the fix/host-git-commit-identity branch August 7, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant