Use symfony http code constants#2123
Merged
carakas merged 10 commits intoforkcms:5.0.0-devfrom Jul 11, 2017
Merged
Conversation
carakas
force-pushed
the
use-symfoncy-http-code-constants
branch
from
2915779 to
c2543bd
Compare
…e of symfony Response class
…those of symfony Response class
… those of symfony Response class
… those of symfony Response class
…those of symfony Response class
… of symfony Response class
…mfony Response class
…fony Response class
…e of symfony Response class
Member
|
👍👍👍 Thumbs up for @carakas |
jeroendesloovere
approved these changes
Jul 3, 2017
jeroendesloovere
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
This removes our own constants for status codes in favour of those of the Symfony Response class