Install script fix#2169
Merged
StijnVrolijk merged 2 commits intomasterfrom Aug 7, 2017
Merged
Conversation
|
@StijnVrolijk, thanks for your PR! By analyzing the history of the files in this pull request, we identified @carakas, @WouterSioen and @jessedobbelaere to be potential reviewers. |
tijsverkoyen
approved these changes
Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing Fork through a script (like on the demo) there's a bit of a hitch.
The Doctrine connection gets created in
ForkCMS\Bundle\InstallerBundle/Service/InstallerConnectionFactory.phpbut that relies on the installation data getting created in theInstallerController. Since we're not using the controller to install Fork, it's not set so we have to set it manually. It does create a few useless calls when actually using the controller (The controller fetches its data, passes it to the installer and the installer passes it back to the controller) but that shouldn't matter too much.I've also removed the
InstallerConnectionsince it was used for fixing theremove_cachetool which is removed in Fork 5 and it prevented Doctrine from creating an actual connection when installing