Make custom for meta not required for update method#2177
Merged
carakas merged 1 commit intoforkcms:masterfrom Aug 14, 2017
Merged
Make custom for meta not required for update method#2177carakas merged 1 commit intoforkcms:masterfrom
carakas merged 1 commit intoforkcms:masterfrom
Conversation
|
@jonasdekeukelaere, thanks for your PR! By analyzing the history of the files in this pull request, we identified @carakas to be a potential reviewer. |
StijnVrolijk
approved these changes
Aug 10, 2017
carakas
approved these changes
Aug 14, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
#2170
Pull request description
In https://github.com/forkcms/forkcms/blob/master/src/Backend/Form/Type/MetaType.php#L272 the update method is called without custom. And in the constructor custom is also not required, so I made it the same.