fix(ui): compact and animate shortcut pills

[forketyfork]

Issue

The Cmd+P and Cmd+O shortcut pills remained visible while the focused terminal ran a foreground process, even though their commands could not reach the shell. Optional pills also kept fixed slots, leaving large gaps when a pill was unavailable.

Solution

Cmd+P and Cmd+O now follow Cmd+T's foreground-process visibility rule, and their overlays close when the focused terminal becomes busy. PillGroupComponent now owns a right-aligned, fixed-spacing layout for all available pills and synchronizes overlay geometry with 200 ms eased transitions when pills are added, removed, or moved.

The change includes visibility, layout, easing, and geometry tests, and updates the user and architecture documentation.

Context

No issue link was provided for this change.

Test plan

• Run Architect with an idle focused shell and verify the available pills are right-aligned with uniform spacing.
• Start and stop a foreground process in the focused terminal; verify Cmd+P, Cmd+O, and Cmd+T disappear while it runs and return afterward.
• Change pill availability and verify remaining pills move into compact positions with a short eased animation, without breaking overlay opening or hit-testing.

[Copilot]

🟡 Changes recommended

Three moderate issues remain in event gating and final animation rendering.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR compacts and animates shortcut pills while hiding shell-dependent actions during foreground processes.

Changes:

• Adds right-aligned pill reflow with eased 200 ms transitions.
• Hides unavailable shortcuts and closes affected overlays.
• Adds tests and updates documentation.

File summaries

File	Review
src/ui/components/worktree_overlay.zig	Applies busy-shell visibility rules.
src/ui/components/recent_folders_overlay.zig	Moderate (1 vote): Gate all events while unavailable so queued keyboard/text input reaches the foreground process.
src/ui/components/pr_dropdown.zig	Moderate (1 vote): Gate the whole handler while unavailable so the open overlay cannot consume foreground-process input.
src/ui/components/pill_group.zig	Moderate (1 vote): Re-arm frame rendering when animation completes so final coordinates are presented.
src/ui/components/expanding_overlay.zig	Supports externally positioned overlay geometry.
src/main.zig	Registers pill-layout tests.
README.md	Documents contextual pill behavior.
docs/ARCHITECTURE.md	Documents pill-group layout ownership.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 3
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The stuck removal-confirmation modal must be cleared when the terminal becomes busy.

Review details

Suppressed comments (1)

Previously missed (1) — in code that hasn't changed since the last review.

src/ui/components/worktree_overlay.zig:144

• If the remove-confirmation modal is open when the focused terminal becomes busy, this early return stops all modal input, but the busy transition only clears creating; it never clears confirming_removal. Because render explicitly continues drawing that modal, it remains visibly stuck while clicks and keys pass through to the terminal. Clear the pending removal (via clearPendingRemoval()) in the busy transition before hiding/collapsing the worktree overlay.

• Files reviewed: 8/8 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

The worktree removal modal becomes non-interactive when the focused terminal becomes busy.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Moderate overlay-state and pill-collision issues can disrupt hit-testing and interaction.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (2)

Previously missed (2) — in code that hasn't changed since the last review.

src/ui/components/pill_group.zig:79

• Seeding every absent pill at its full-row slot can place it directly on top of an existing compacted pill when it becomes available. For example, with only PR + Help visible, PR is at x=680 and the hidden Recent pill is also seeded at x=680; adding a recent folder renders both there until PR moves left, and the higher-z Recent component intercepts clicks over PR. Stage the new pill until the occupied slot clears, or use a collision-free entrance path so layout animation does not make hit-testing ambiguous.
  src/ui/components/pr_dropdown.zig:335
• The busy transition hides rendering immediately but leaves the overlay in a 200 ms .Collapsing state. If focus moves to an idle terminal before that finishes, the PR pill becomes visible again at the partially collapsed panel size, and its mouse handler cannot open it until the animation ends. Complete the hidden close immediately and reset the flow state so the pill always returns in .Closed.

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Newly added pills snap instead of easing, and the worktree picker can reappear mid-collapse after a brief busy period.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

src/ui/components/worktree_overlay.zig:297

• The busy transition still leaves an open worktree picker in .Collapsing. If the foreground process exits within 200 ms, available is refreshed and the picker becomes visible again partway through its collapse, rather than returning as a compact pill. Close every non-closed state immediately here, as the recent-folder and PR pickers do, and reset the flow animation state.

                self.clearPendingRemoval();

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🟡 Changes recommended

Entering pills can overlap existing pills while remaining interactive, causing unsafe click routing.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

A moderate animation-state bug remains, and the UI geometry changes require human validation.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 1
• Review effort level: Balanced

[Copilot]

🔵 Needs a closer look

Four moderate input-handling and hit-testing issues remain unresolved.

Review details

Suppressed comments (4)

Previously missed (3) — in code that hasn't changed since the last review.

src/ui/components/pr_dropdown.zig:147

• Preserve and handle an outstanding Escape release before rejecting unavailable input. If the shell becomes busy after this picker consumes Escape key-down, this gate—and the new immediate-close/interactivity cleanup that clears escape_pressed—allows runtime.zig:2613-2623 to send the later key-up as an unexpected ESC byte to the foreground process. Keep the pending-release flag through the busy close and consume that key-up before this gate.
  src/ui/components/recent_folders_overlay.zig:156
• Preserve and handle an outstanding Escape release before rejecting unavailable input. If the shell becomes busy after this picker consumes Escape key-down, this gate—and the new immediate-close/interactivity cleanup that clears escape_pressed—allows runtime.zig:2613-2623 to send the later key-up as an unexpected ESC byte to the foreground process. Keep the pending-release flag through the busy close and consume that key-up before this gate.
  src/ui/components/worktree_overlay.zig:137
• Preserve and handle an outstanding Escape release before rejecting unavailable input. If the shell becomes busy after this picker consumes Escape key-down, this gate—and the new immediate-close/interactivity cleanup that clears escape_pressed—allows runtime.zig:2613-2623 to send the later key-up as an unexpected ESC byte to the foreground process. Keep the pending-release flag through the busy close and consume that key-up before this gate.

src/ui/components/pill_group.zig:176

• An entering pill can still activate an existing pill underneath it. For example, halfway through the tested PR entrance the PR occupies x=760–800 while Help occupies x=740–780; the PR is non-interactive here, so reverse z-order dispatch lets Help consume a click at x=770 and open unexpectedly. Either consume pointer events over entering-pill bounds at the pill-group layer or use an entrance path that never overlaps an interactive pill.

    fn pillInteractive(self: *const PillLayout, pill: PillKind) bool {
        const idx = @intFromEnum(pill);
        return self.visible[idx] and !self.entering[idx];

• Files reviewed: 8/8 changed files
• Comments generated: 0 new
• Review effort level: Balanced

[forketyfork]

Addressed the four issues from the latest Copilot review in 2815416: pending Escape releases remain consumed across busy closes, entering-pill pointer bounds are intercepted by the pill group, and the related regression coverage is in place. Local tests, build, lint, formatting, and diff checks pass. The review had no unresolved inline threads.

[Copilot]

🔵 Needs a closer look

The UI animation, geometry, and hit-testing changes warrant final human review.

Review details

• Files reviewed: 8/8 changed files
• Comments generated: 0 new
• Review effort level: Balanced