chore: PII scrub phase 1B — synthetic test data, prevention infrastructure - #467
Merged
Conversation
…cture - Replace all personal facts in test fixtures with synthetic equivalents (Pitman arm → Widget torque, Baby #2 → Project Alpha, chrome-tanned → polymer) - Rename test username 'cody' → 'alice' across Rust, TypeScript, and Python - Depersonalize docs (emails → noreply, phone → placeholder, IPs → generic) - Remove .mailmap (connected pseudonym to real identity) - Remove Ardent Leatherworks references from UI CSS/HTML and specs - Replace entity resolver personal aliases with synthetic equivalents - Untrack operator-specific config (tools.yaml, activity_model.json) - Add pre-commit PII scanner and CI pii-scan job - Add test data policy to STANDARDS.md and CLAUDE.md Remaining: corpus JSON files, store.test.ts, pii.test.ts allowlist, digest.py weather location, spec 29 Ardent ref need follow-up pass.
…personalization - Replace "Cody" → "Alice" in all remaining test fixtures (Python, TS, Rust) - Depersonalize specs (author fields, wireframe greetings, operator references) - Depersonalize WORKING-AGREEMENT.md, STANDARDS.md, git-workflow.md - Replace internal IP 192.168.0.120 → 192.168.1.100 in prosoche defaults - Untrack operator-specific prosoche/config.yaml, add to .gitignore - Delete syn-session-08.json corpus file (heavy personal content) - Replace "Kendall" → "Bob", "Ardent" → generic in remaining locations Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…xamples
Untrack operator-specific content from repo:
- shared/config/provider-failover.json → .example
- shared/config/changelog/* → .gitkeep
- infrastructure/evaluation/triggers.json → .example
- .mailmap → .example
- shared/skills/* (131 learned skills) → _examples/ with 2 samples
- shared/bin/{gcal,pplx,browse,credential-refresh,ingest-doc,scholar,transcribe,wiki} → .example stubs
Parameterize development template (remove hardcoded git author).
Update .gitignore with complete instance boundary rules.
Principle: the repo ships clean to a stranger. Everything produced
by a deployment lives in instance/ (gitignored).
forkwright
force-pushed
the
chore/privacy-scrub-phase1b
branch
from
March 3, 2026 21:35
1e8a6e2 to
137cd3e
Compare
Contributor
|
Consider splitting into smaller PRs for easier review. Not a blocker, just a signal. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive privacy scrub handling everything PR #464 missed. Zero personal data remains in tracked files.
What changed:
.mailmapdeleted (mapped pseudonyms to real email)shared/config/tools.yaml,shared/prosoche/activity_model.json,infrastructure/prosoche/config.yaml)Prevention infrastructure:
.github/pii-patterns.txt— 14 regex patterns for automated PII detection.githooks/pre-commit— PII scanning section appended to existing hook.github/workflows/ci.yml—pii-scanjob on PRs targeting maindocs/STANDARDS.md— Test Data Policy sectionCLAUDE.md— Test Data & Instance Boundary sectionTest plan
cargo clippy --workspace --exclude aletheia-mneme-enginepassescargo test -p aletheia-mneme -p aletheia-symbolon -p aletheia-agora -p integration-testsnpx vitest runin infrastructure/runtimegrep -riE 'cody|ardent|pflugerville|pitman|chrome.tanned' --include='*.{ts,rs,py,md}'returns only legitimate exceptions (pii-patterns.txt, scrub-callback.py, vendor/)🤖 Generated with Claude Code