Skip to content

unwired: DynCurationService trait is empty — library curation quality assessment and upgrade eligibility are unreachable #470

Description

@forkwright

Finding

DynCurationService in harmonia is a zero-method trait. DefaultCurationService implements assess_quality, check_upgrade_eligibility, and health_report for library curation. The CurationAdapter inner field carries #[expect(dead_code)]. Route handlers in paroche/src/routes have zero hits for state.curation. Curation capabilities are unreachable from HTTP.

Evidence

crates/archon/src/serve.rs:45: #[expect(dead_code)] on CurationAdapter inner field. DynCurationService definition: zero methods. grep 'state.curation' paroche/src/routes = 0 hits.

Why this matters

Library health reporting, quality assessment, and upgrade eligibility checks — features that identify poor-quality files and suggest replacements — are fully implemented but inaccessible. Operators with large libraries who depend on curation to identify and improve low-quality acquisitions have no API surface to invoke these capabilities.

Desired correction

Define assess_quality, check_upgrade_eligibility, and health_report on DynCurationService. Add route handlers in paroche/src/routes that call through state.curation. Remove the dead_code suppression on CurationAdapter once a route handler uses it.

Done when: at least one HTTP route calls a method on DynCurationService, the trait has defined methods, and a test exercises the curation endpoint.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions