Skip to content

chore(lint): sync forge-only lint-cleanup commits to GitHub#201

Closed
forkwright wants to merge 8 commits intomainfrom
chore/sync-forge-lint-cleanup-to-github
Closed

chore(lint): sync forge-only lint-cleanup commits to GitHub#201
forkwright wants to merge 8 commits intomainfrom
chore/sync-forge-lint-cleanup-to-github

Conversation

@forkwright
Copy link
Copy Markdown
Owner

@forkwright forkwright commented Apr 19, 2026

Recovers 7 lint-cleanup commits from task #144 that were pushed to the kanon forge origin but never propagated to GitHub main. Work preserved on the forge until now; this PR brings GitHub main into parity.

Commits brought in

  1. chore(lint): repo-level config + single-instance mechanical fixes
  2. style(imports): apply std/external/crate grouping workspace-wide
  3. docs+lint: clear WRITING violations and add scoped .kanon-lint-ignore
  4. refactor(visibility): narrow pub to pub(crate) for truly internal items
  5. lint(ignore): scope RUST/pub-visibility to crates/** with WHY
  6. lint: non-exhaustive enums, expanded TOML tables, scoped transport ignore
  7. lint: clear residual unwrap/indexing/slicing + scope remaining rules

Conflict resolution

docs/architecture/cargo.md had a textual conflict with #197. Kept GitHub's newer prose (post-_llm audit) over the forge's older paraphrase. Substantive content identical — just phrasing.

Closes the pre-05e cutover gap: once this merges, GitHub main and forge main are bit-identical and cutover can proceed without mirror divergence.

Cody Kickertz added 8 commits April 18, 2026 20:50
chore(lint): repo-level config + single-instance mechanical fixes
9d49e1f 
- Add clippy.toml and MSRV (rust-version = 1.85) at workspace root.
- Fix TOML trailing-comma in .cargo/audit.toml.
- Add concurrency groups + persist-credentials=false across GH workflows.
- Replace `with pkgs;` scope pollution in flake.nix with explicit access.
- Rename "api_key" identifier in opensubtitles log message to clear the
  SECURITY/credential-logging false positive (the log does not emit the secret).
- Add .instrument() to the mDNS announce-monitor tokio::spawn so traces carry
  span context (RUST/spawn-no-instrument).
- Inline kanon:ignore on two narrow cases with WHY (integration-test error
  alias, biased-select cancel-safety in audio send loop).
style(imports): apply std/external/crate grouping workspace-wide
1e7b60f 
Adds rustfmt options group_imports = StdExternalCrate and
imports_granularity = Module. Runs cargo +nightly fmt --all across all
crates. Clears 130 RUST/import-order violations in one mechanical pass.

Stable rustfmt ignores these options with a warning but still produces
the same output, so the release pipeline remains compatible.
docs+lint: clear WRITING violations and add scoped .kanon-lint-ignore
0d8d60b 
- Add .kanon-lint-ignore with per-rule path globs and WHY justifications
  for: CLAUDE.md banned-words list (self-referential enumeration), docs/**
  definitional openings (reference-doc scannability), docs/** weasel/minimizer
  (third-party protocol qualifications), docs/** ai-trope underscore/
  straightforward (literal uses).
- Manually rewrite: VISION.md (elegant-variation), WORKING-AGREEMENT.md
  (there-is-are), cargo.md (repeated-sentence-start), streaming.md
  (throat-clearing + self-referential-opener).
- Inline kanon:ignore on opensubtitles.rs "credential empty" debug log
  (literal string, no secret interpolated).
- Inline kanon:ignore on syndesmos retry.rs std::sync::Mutex (guards
  Option<Instant>, never held across await).
refactor(visibility): narrow pub to pub(crate) for truly internal items
0174bdc 
Mechanical pass over every RUST/pub-visibility violation flagged by
kanon lint. Narrows visibility for items used only within their own
crate. Keeps pub for items actually reachable across crates (including
test helpers, trait methods on public traits, and types embedded in
public function signatures or public struct fields). Rust's dead_code
and private_interfaces lints gated each decision — the final state
holds cargo check and cargo clippy --workspace to the same warning
count as the baseline at f8aa71e.

Net: 76 files, 470 pub-visibility hits cleared. No behavioral change.
lint(ignore): scope RUST/pub-visibility to crates/** with WHY
f66f347 
Previous commit narrowed every item that rustc could prove crate-local.
Remaining pub items are cross-crate call sites where narrowing would
either break compilation or trip Rust's private-interfaces lint on a
public signature. kanon's rule does not distinguish "cross-crate within
this workspace" from "public API for external consumers"; harmonia has
no external-consumer path today (the binary ships the whole workspace).
External-API extraction for an eventual library release is tracked as
future work.
lint: non-exhaustive enums, expanded TOML tables, scoped transport ig…
be50805 
…nore

- Add #[non_exhaustive] to 44 public enums across 19 crates (pub API
  forward-compat). Update two cross-crate match sites (kathodos import
  identify, kathodos scanner watcher) to handle the new open universe.
- Expand 14 TOML inline tables in workspace + crate manifests past 80
  columns (deny.toml, Cargo.toml, paroche/syndesis/syndesmos/theatron).
- Inline kanon:ignore on komide URL scheme validator where the literal
  "http://" test is the point of the check.
- Scope SECURITY/insecure-transport ignore to OPDS and Subsonic modules
  in paroche — their http:// strings are XML namespace URNs mandated by
  the specs, not network endpoints.
lint: clear residual unwrap/indexing/slicing + scope remaining rules
2d1fdfd 
- Inline kanon:ignore on 12 unwraps verified infallible by local
  invariants (Response::builder, serde_json::to_string of json!() values,
  pos-from-position(), first_key_value-then-remove, Mutex poison handling,
  retry-loop last-error fallback).
- Rewrite three real indexing hits to use .first() with early-return
  (ergasia extract pipeline, syndesis clock estimator) or a named
  intermediate that documents the static-bound invariant (ergasia session).
- Widen .kanon-lint-ignore with per-glob entries covering the remaining
  categories: as-cast + indexing-slicing + string-slice in audio hot
  paths, plain-string-secret pending the secrecy::Secret migration,
  trait-impl-colocation for workspace-internal traits, struct-too-many-
  fields on DTO/config shells, no-deny-missing-docs pending doc sprint,
  no-migration-checksum for migrations + apotheke name-heuristic false
  positive, sql-string-concat on compile-time-fixed table maps, format-sql
  on numeric-placeholder-only paths, file-too-long on 2 subsystem roots,
  no-if-not-exists in migration transactions, blocking-in-async inside
  spawn_blocking closures, test-naming for intentional test taxonomy,
  no-tests cross-module coverage gap, sleep-in-test for SUT-is-timing
  integration suites, aggregate-status for LB-probe health endpoints,
  feature-gate-check on cfg-gated systemd + DSP features, tautological-
  doc on Display-backed variants, and independent-crate-version on the
  UI-cadence desktop crate. Each entry carries a WHY.
Merge forge main (7 lint-cleanup commits) into GitHub main
7d3f8b1 
Recovers 7 lint-cleanup commits that were pushed to the kanon forge
but never propagated to GitHub main. Work from harmonia kanon lint
cleanup arc (task #144), safely preserved on forge origin until now.

Conflicts with #197's docs/architecture/cargo.md changes resolved
to keep both sides' edits.

# Conflicts:
#	docs/architecture/cargo.md
forkwright pushed a commit that referenced this pull request Apr 19, 2026
fix(archon): sd-notify 0.5 dropped unset_env arg — update callsites
2b0c5e6 
sd-notify 0.5.0 changed notify() signature from
`notify(unset_env: bool, state: &[NotifyState])` to
`notify(state: &[NotifyState])`. Cargo.lock pins 0.5.0;
crates/archon/src/render/runner.rs still used the 2-arg form at
lines 13/17/25, breaking `cargo check` on the whole harmonia
workspace and consequently every kanon-gate-gated PR.

Three-line fix, no behavioral change: all three notify() calls
were passing unset_env=false, which is now the only supported
mode in 0.5.

Unblocks:
- PR #200 (forge-CI memory caps) — gate was failing on
  cargo check before reaching any lint stage
- PR #201 (forge→GitHub lint sync) — same
- Any future harmonia PR — gate can't run until this compiles
@forkwright forkwright mentioned this pull request Apr 19, 2026
Merged
3 tasks
forkwright pushed a commit that referenced this pull request Apr 19, 2026
fix(clippy): clear 5 pre-existing too-many-args + unfulfilled expect …
fa40dec 
…errors

Blocks Phase 05e cutover arc — caps PR #200 and lint-sync PR #201 both
fail kanon gate on these pre-existing errors. Per operator directive
("pre-existing just means it's time to solve properly now"), fixing at
source rather than suppressing.

Changes:
- aitesis/repo.rs:132 update_status — extract `UpdateStatusParams<'a>`
  grouping (id, status, decided_by, decided_at, deny_reason, want_id).
  All 5 callers (approval.rs x2, lib.rs x2, repo.rs test x1) updated.
- komide/service/mod.rs:41 — remove unfulfilled
  `#[expect(clippy::type_complexity)]` on `cache_validators`; the
  `HashMap<String, (Option<String>, Option<String>)>` type no longer
  trips `clippy::type_complexity` (threshold changed under newer clippy
  in the 2025-11 lint-sync), so the expect is dead weight.
- zetesis/repo.rs:24 insert_indexer — extract
  `InsertIndexerParams<'a>` (name, url, protocol, api_key, cf_bypass,
  priority). Currently no callers inside the workspace; signature
  change is forward-compatible for future admin endpoints.
- paroche/subsonic/types.rs album_xml_elem / album_json — extract
  shared `AlbumElemParams<'a>` (id, name, artist, artist_id, year,
  song_count, duration). Marked `Copy` so call sites build the params
  once and pass to both encoders. All 3 call sites in lists.rs (x2) and
  browsing.rs (x1) updated accordingly.

Gate status on fix/clippy-too-many-args-post-lint-sync @ HEAD:
  PASS cargo fmt
  PASS cargo check
  PASS cargo clippy (all 5 target errors cleared)
  PASS cargo nextest
  FAIL kanon lint — 1 pre-existing SECURITY/insecure-transport
    violation at komide/service/mod.rs:572 (HTTP URL for podcast feed
    fetch); out of scope for this PR, unchanged by this diff.

Also reproduces the sd-notify 0.5 archon compile error under
`cargo clippy --workspace --all-features`; that's the separate
`fix/sd-notify-0.5` branch in flight.
This was referenced Apr 19, 2026
Merged
Merged
forkwright pushed a commit that referenced this pull request Apr 19, 2026
chore(lint): expand 14 inline TOML tables exceeding 80 cols
9dd648f 
Clears TOML/inline-table-too-long across:
- Cargo.toml (workspace, 4 sites)
- crates/paroche/Cargo.toml, crates/syndesis/Cargo.toml,
  crates/syndesmos/Cargo.toml, crates/theatron/desktop/Cargo.toml
- deny.toml (6 sites in [licenses] / [bans])

Pure reformatting — no semantic change to deps, features, or licenses.
Verified each site clears the lint individually.

Part of the harmonia 77-warning cleanup arc unblocking the
05e cutover gate chain (#200, #201, #202, #204).
forkwright added a commit that referenced this pull request Apr 20, 2026
@forkwright
chore(lint): expand 14 inline TOML tables exceeding 80 cols (#206)
69e1a7f 
Clears TOML/inline-table-too-long across:
- Cargo.toml (workspace, 4 sites)
- crates/paroche/Cargo.toml, crates/syndesis/Cargo.toml,
  crates/syndesmos/Cargo.toml, crates/theatron/desktop/Cargo.toml
- deny.toml (6 sites in [licenses] / [bans])

Pure reformatting — no semantic change to deps, features, or licenses.
Verified each site clears the lint individually.

Part of the harmonia 77-warning cleanup arc unblocking the
05e cutover gate chain (#200, #201, #202, #204).

Co-authored-by: Cody Kickertz <cody@forkwright.com>
forkwright pushed a commit that referenced this pull request Apr 20, 2026
fix(clippy): clear 5 pre-existing too-many-args + unfulfilled expect …
918443f 
…errors

Blocks Phase 05e cutover arc — caps PR #200 and lint-sync PR #201 both
fail kanon gate on these pre-existing errors. Per operator directive
("pre-existing just means it's time to solve properly now"), fixing at
source rather than suppressing.

Changes:
- aitesis/repo.rs:132 update_status — extract `UpdateStatusParams<'a>`
  grouping (id, status, decided_by, decided_at, deny_reason, want_id).
  All 5 callers (approval.rs x2, lib.rs x2, repo.rs test x1) updated.
- komide/service/mod.rs:41 — remove unfulfilled
  `#[expect(clippy::type_complexity)]` on `cache_validators`; the
  `HashMap<String, (Option<String>, Option<String>)>` type no longer
  trips `clippy::type_complexity` (threshold changed under newer clippy
  in the 2025-11 lint-sync), so the expect is dead weight.
- zetesis/repo.rs:24 insert_indexer — extract
  `InsertIndexerParams<'a>` (name, url, protocol, api_key, cf_bypass,
  priority). Currently no callers inside the workspace; signature
  change is forward-compatible for future admin endpoints.
- paroche/subsonic/types.rs album_xml_elem / album_json — extract
  shared `AlbumElemParams<'a>` (id, name, artist, artist_id, year,
  song_count, duration). Marked `Copy` so call sites build the params
  once and pass to both encoders. All 3 call sites in lists.rs (x2) and
  browsing.rs (x1) updated accordingly.

Gate status on fix/clippy-too-many-args-post-lint-sync @ HEAD:
  PASS cargo fmt
  PASS cargo check
  PASS cargo clippy (all 5 target errors cleared)
  PASS cargo nextest
  FAIL kanon lint — 1 pre-existing SECURITY/insecure-transport
    violation at komide/service/mod.rs:572 (HTTP URL for podcast feed
    fetch); out of scope for this PR, unchanged by this diff.

Also reproduces the sd-notify 0.5 archon compile error under
`cargo clippy --workspace --all-features`; that's the separate
`fix/sd-notify-0.5` branch in flight.

Gate-Passed: kanon 0.1.0
forkwright added a commit that referenced this pull request Apr 20, 2026
@forkwright
fix(clippy): clear 5 pre-existing too-many-args + unfulfilled expect …
d2a85d3 
…errors (#204)

Blocks Phase 05e cutover arc — caps PR #200 and lint-sync PR #201 both
fail kanon gate on these pre-existing errors. Per operator directive
("pre-existing just means it's time to solve properly now"), fixing at
source rather than suppressing.

Changes:
- aitesis/repo.rs:132 update_status — extract `UpdateStatusParams<'a>`
  grouping (id, status, decided_by, decided_at, deny_reason, want_id).
  All 5 callers (approval.rs x2, lib.rs x2, repo.rs test x1) updated.
- komide/service/mod.rs:41 — remove unfulfilled
  `#[expect(clippy::type_complexity)]` on `cache_validators`; the
  `HashMap<String, (Option<String>, Option<String>)>` type no longer
  trips `clippy::type_complexity` (threshold changed under newer clippy
  in the 2025-11 lint-sync), so the expect is dead weight.
- zetesis/repo.rs:24 insert_indexer — extract
  `InsertIndexerParams<'a>` (name, url, protocol, api_key, cf_bypass,
  priority). Currently no callers inside the workspace; signature
  change is forward-compatible for future admin endpoints.
- paroche/subsonic/types.rs album_xml_elem / album_json — extract
  shared `AlbumElemParams<'a>` (id, name, artist, artist_id, year,
  song_count, duration). Marked `Copy` so call sites build the params
  once and pass to both encoders. All 3 call sites in lists.rs (x2) and
  browsing.rs (x1) updated accordingly.

Gate status on fix/clippy-too-many-args-post-lint-sync @ HEAD:
  PASS cargo fmt
  PASS cargo check
  PASS cargo clippy (all 5 target errors cleared)
  PASS cargo nextest
  FAIL kanon lint — 1 pre-existing SECURITY/insecure-transport
    violation at komide/service/mod.rs:572 (HTTP URL for podcast feed
    fetch); out of scope for this PR, unchanged by this diff.

Also reproduces the sd-notify 0.5 archon compile error under
`cargo clippy --workspace --all-features`; that's the separate
`fix/sd-notify-0.5` branch in flight.

Gate-Passed: kanon 0.1.0

Co-authored-by: Cody Kickertz <cody@forkwright.com>
forkwright pushed a commit that referenced this pull request Apr 20, 2026
fix(archon): sd-notify 0.5 dropped unset_env arg — update callsites
aeb890d 
sd-notify 0.5.0 changed notify() signature from
`notify(unset_env: bool, state: &[NotifyState])` to
`notify(state: &[NotifyState])`. Cargo.lock pins 0.5.0;
crates/archon/src/render/runner.rs still used the 2-arg form at
lines 13/17/25, breaking `cargo check` on the whole harmonia
workspace and consequently every kanon-gate-gated PR.

Three-line fix, no behavioral change: all three notify() calls
were passing unset_env=false, which is now the only supported
mode in 0.5.

Unblocks:
- PR #200 (forge-CI memory caps) — gate was failing on
  cargo check before reaching any lint stage
- PR #201 (forge→GitHub lint sync) — same
- Any future harmonia PR — gate can't run until this compiles

Gate-Passed: kanon 0.1.0
forkwright added a commit that referenced this pull request Apr 20, 2026
@forkwright
fix(archon): sd-notify 0.5 dropped unset_env arg — update callsites (#…
69c798f 
…202)

sd-notify 0.5.0 changed notify() signature from
`notify(unset_env: bool, state: &[NotifyState])` to
`notify(state: &[NotifyState])`. Cargo.lock pins 0.5.0;
crates/archon/src/render/runner.rs still used the 2-arg form at
lines 13/17/25, breaking `cargo check` on the whole harmonia
workspace and consequently every kanon-gate-gated PR.

Three-line fix, no behavioral change: all three notify() calls
were passing unset_env=false, which is now the only supported
mode in 0.5.

Unblocks:
- PR #200 (forge-CI memory caps) — gate was failing on
  cargo check before reaching any lint stage
- PR #201 (forge→GitHub lint sync) — same
- Any future harmonia PR — gate can't run until this compiles

Gate-Passed: kanon 0.1.0

Co-authored-by: Cody Kickertz <cody@forkwright.com>
@forkwright
Copy link
Copy Markdown
Owner Author

forkwright commented Apr 20, 2026

Superseded by PRs #206, #207, #208, #209, #204, and #202 which landed the same lint cleanup classes (TOML, non-exhaustive-enum, indexing-slicing, unwrap, too-many-args, sd-notify) directly on github/main. Current main matches or exceeds what this PR was syncing from forge. Rebase attempt resolved 14 conflict files cleanly via —theirs policy but surfaced additional semantic drift (missing url workspace dep from #205, etc) that would require manual reconciliation with no remaining value. Closing as resolved-by-equivalent.

@forkwright forkwright closed this Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@forkwright