fix(lint): replace 3 direct indexing sites with .get() + None handling#208
Merged
forkwright merged 1 commit intomainfrom Apr 20, 2026
Merged
fix(lint): replace 3 direct indexing sites with .get() + None handling#208forkwright merged 1 commit intomainfrom
forkwright merged 1 commit intomainfrom
Conversation
Clears RUST/indexing-slicing in:
- ergasia/src/extract/pipeline.rs:46
- ergasia/src/session.rs:50
- syndesis/src/clock/estimator.rs:204
For each site: all three indices are provably in-bounds, so replaced with
.first()/.get() + unwrap_or_else(|| unreachable!("...")) documenting the
invariant instead of relying on a silent panic.
Part of the harmonia 77-warning cleanup arc unblocking 05e cutover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces 3
RUST/indexing-slicingdirect indexing calls with.first()/.get()+unwrap_or_else(|| unreachable!(...))to document the safety invariant explicitly rather than relying on silent panics.Sites fixed:
ergasia/src/extract/pipeline.rs:46— archives is non-empty (checked viais_empty()guard)ergasia/src/session.rs:50—listen_port_rangeis[u16; 2], so indices 0 and 1 are always validsyndesis/src/clock/estimator.rs:204— samples has exactly 1 element (checked vialen() == 1guard)All affected crate tests pass. Gate fails only on the ~74 pre-existing warnings in other crates (aitesis/komide/zetesis/paroche) handled by parallel agents.
Part of the harmonia 77-warning cleanup arc unblocking 05e cutover.