fix(epignosis): metadata provider correctness (TVDB cache, TMDB cross-ref, AcoustID) - #494
Merged
Conversation
…-ref, AcoustID) - #416: TvdbProvider caches its bearer token (double-checked RwLock, 24h TTL) instead of doing a fresh login on every search and get_metadata. - #417: TV secondary enrichment cross-references the TVDB id through TMDB's /find/{id}?external_source=tvdb_id and fetches /tv/{id} in the correct namespace, instead of feeding a TVDB id into /movie/{id}; fails closed to None on a find miss. - #471: AcoustIdProvider computes a real chromaprint fingerprint via the fpcalc subprocess (runtime probe, kill_on_drop) and feeds it to the lookup; every subprocess/parse failure is a typed error, never a panic. - #458: known-answer tests for the OpenSubtitles compute_file_hash algorithm (and a corrected doc comment: wrapping sum, not XOR). Closes #416 Closes #417 Closes #471 Closes #458 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:8b3f93309bfed764e026cc59556dac18645934a1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #416, #417, #471, #458. TVDB bearer-token caching; TMDB /find external-id cross-reference (fixes ID-namespace bug, fails closed on miss); AcoustID fpcalc fingerprinting (typed failures, no panic); OpenSubtitles hash known-answer tests. kanon gate --full green.