fix(paroche): report real list totals instead of page-slice length - #508
Merged
Conversation
Closes #478 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:25f58a174c9001228d1d40e626972b3dd97e9c2b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paginated list handlers reported
total = items.len() as u64— the page-slice length, not the collection total — so pagination metadata was wrong for any list larger than one page.Adds 9
count_*repo fns in apotheke (mirroring the #372count_trackspattern) and fixes all 10 affected handlers (movie/book/comic/audiobook/tv/news/podcast/music-release-groups/wanted via the repo fns; indexer via an inlineSELECT COUNT(*)matching its existing inline-sqlx style). Each now reports the real total.Gate:
kanon gate --fullgreen (fmt, check, clippy-D warnings --all-targets, nextest 1731/1731, deny, lint).Closes #478