fix(paroche): close IPv4-compatible-IPv6 SSRF bypass and resolve magnet trackers - #511
Merged
Conversation
…et trackers Closes #479 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:12fd5a7873ff9563ffcccfa99be9dd60ce078487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes three SSRF gaps in the download-URL guard (
crates/paroche/src/net_validate.rs):::/96) bypass —ip_is_disallowedonly judged the IPv4-mapped form (::ffff:a.b.c.d); the deprecated compatible form (::127.0.0.1) skipped every v4 range check and reached loopback. Now the v6 arm checks mapped → v6-native ranges →::/96embedded-v4 (in that order, so::/::1stay v6-judged).Gate:
kanon gate --fullgreen (clippy-D warnings, nextest 1729, deny, lint). New tests cover the::/96forms and the unresolvable-tracker case.Closes #479