fix(lint): mark the RFC 6598 range citation as a reviewed reference - #669
Merged
Conversation
OIKOS/private-content matched `100.64.0.0/10` in the comment documenting why `ip_is_disallowed` rejects CGNAT space. That literal is the range's own base address and prefix length as RFC 6598 defines them, not a fleet host address, so every correct implementation of this rejection has to name the range — redacting it cannot satisfy the rule, which is why the rule documents `pii-allow` for a deliberate, reviewed reference. Both sites fired on `main`, and harmonia's `gate-attestation` job is a standalone trailer grep with no `full-gate-build` fallback, so while the gate's lint stage was red no branch in this repo could earn a `Gate-Passed` trailer at all.
forkwright
pushed a commit
that referenced
this pull request
Aug 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.2.2](v0.2.1...v0.2.2) (2026-08-03) ### Bug Fixes * **deps:** bump event-listener to 5.4.2 for RUSTSEC-2026-0221 ([#679](#679)) ([ce56e10](ce56e10)) * **desktop:** stop the standalone lockfile drifting behind releases ([#675](#675)) ([f07ca78](f07ca78)) * **epignosis:** hold the book cross-reference test ids in one place ([#676](#676)) ([8f2b9d0](8f2b9d0)) * **lint:** mark the RFC 6598 range citation as a reviewed reference ([#669](#669)) ([9f56867](9f56867)) * **syndesis:** give each TLS identity test its own temp directory ([#674](#674)) ([a9ef578](a9ef578)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
ip_is_disallowedincrates/eksetasis/src/client/mod.rsandcrates/paroche/src/net_validate.rscarries the same comment documenting why CGNAT space is rejected, and cites the range literal100.64.0.0/10. The OIKOS/private-content lint matches that literal as a possible fleet host address and flags it, with no way to satisfy the rule by redacting the citation — the literal is the RFC 6598 range's own base address and prefix length, not a host. Both sites fired onmain; sincegate-attestationhere is a standalone trailer check with no full-build fallback, no branch in this repo could earn aGate-Passedtrailer while the lint stage stayed red.Change
Adds a
pii-allowannotation to both comments marking the citation as a reviewed, deliberate reference, matching the escape hatch the rule itself documents. No code logic changes — theip_is_disallowedrejection behavior is identical before and after.Verification
Comment-only change with no behavior difference; verification is that the OIKOS/private-content lint stage stops flagging these two sites (CI/lint-only, no runtime test applicable).