chore(regions): refresh service version matrix#400
Conversation
WalkthroughUpdated documented Helm ChangesHelm version mappings
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
71ede14 to
73f3819
Compare
✅ Approve — automated reviewThe version matrix refresh has been reviewed. The two previously flagged blockers — chart version not bumped and helm-docs README files not regenerated — were raised by the automated bot review and are addressed: the "codex" reviewer confirms that chart version bumps, parent lock refresh, and regenerated README files are all present in the PR. No new concrete issues were identified by any reviewer. The PR appears ready to merge. No findings. |
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot posted 1 new inline finding.
Summary: #400 (comment)
Bump pinned service versions across the v2.0–v3.2 region tracks: auth v2.4.3, ledger, orchestration, payments, reconciliation, search, wallets and webhooks patch upgrades.
73f3819 to
e22eaf3
Compare
NumaryBot
left a comment
There was a problem hiding this comment.
🛑 Changes requested — automated review
The service version matrix refresh in charts/regions/values.yaml is missing two mandatory accompanying changes. First, the chart version in Chart.yaml has not been bumped from the already-published 3.13.0 tag; because the release workflow skips existing versions, the updated defaults would never be packaged or shipped. Second, the helm-docs-generated README files have not been regenerated to reflect the new defaults, which will cause the CI "Dirty" check to fail. Both issues must be resolved before this PR can merge. No other correctness issues were found in the modified lines.
Findings outside the diff
🔴 [blocker] Chart version not bumped after changing defaults — charts/regions/Chart.yaml
The chart version in Chart.yaml remains at 3.13.0, which is already tagged as regions-3.13.0. The release workflow uses cr upload --skip-existing, so the updated service version matrix in values.yaml will be silently skipped and never published to users.
Suggestion: Bump the chart version in charts/regions/Chart.yaml (e.g. to 3.14.0), and update the version/lock entries in the parent charts/formance chart accordingly so users can receive the refreshed pins.
Summary: #400 (comment)
NumaryBot
left a comment
There was a problem hiding this comment.
NumaryBot review complete: no remaining inline findings.
Resolved 1 stale NumaryBot review thread (1 fixed, 0 outdated).
Summary: #400 (comment)
Summary
Refreshes the pinned service versions in the
regionschart version matrix across the supportedv2.0–v3.2tracks:auth→v2.4.3ledger,orchestration,payments,reconciliation,search,wallets, andwebhooks→ latest compatible patch releasesv2.3.22on Stackv3.1andv2.4.12on Stackv3.2Publishes the refreshed defaults through the complete Helm chart cascade:
regions:3.13.0→3.13.1formance:1.16.0→1.16.1charts/formance/Chart.lockto pinregions 3.13.1formance, andregionsREADMEsNo Helm templates or values schemas are changed.
Test plan
just pre-commitcompleted and regenerated dependencies/documentationhelm lint --strict charts/regionshelm template regions charts/regionshelm lint --strict charts/formancehelm template formance charts/formancev2.3.22andv2.4.12releases and multi-architecture OCI images