feat(connectivity): provision OpenTelemetry monitoring on the delegated resource

[Dav-14]

Summary

Wire OpenTelemetry observability into the Connectivity module, mirroring the Ledger v3 pattern.

• Resolve the stack's OTEL configuration via settings.GetOpenTelemetryConfiguration(ctx, stack.Name, "connectivity"). This is collector-aware: it points the signals at otel-collector.<stack>:4318 when the per-stack collector Service exists, otherwise it honours the opentelemetry.* Settings.
• Embed the resolved config inline in the delegated resource's spec.monitoring (same shape as Ledger v3's Cluster.spec.monitoring). The connectivity operator's MonitoringConfig is a struct embedded in the CRD spec — there is no separate Monitoring object to create or reference. The connectivity operator turns spec.monitoring into OTEL_* env vars on the workload.
• Each present signal is enabled with the otlp exporter; traces are batched, metrics carry runtime instrumentation — matching the Ledger v3 mapping.

Idempotency

The whole spec.monitoring block is rebuilt inside the existing CreateOrUpdate mutate closure on every reconcile, and pruned (RemoveNestedField) when telemetry is disabled — so repeated reconciles converge to the same object.

Test plan

• go test ./internal/resources/connectivities/... green
• New unit tests: inline signal mapping, sorted resource attributes, idempotency (byte-for-byte identical spec on re-apply), omission of unconfigured signals, and pruning when disabled
• New helpers at 100% coverage (applyConnectivityMonitoring, connectivityMonitoringSpec)
• just pre-commit (tidy, lint, generate, manifests, helm, docs, settings-catalog)

Notes

• Base branch is feat/connectivity-module — this stacks the observability wiring on top of the connectivity module work.
• End-to-end OTEL_* env-var emission is owned by the connectivity operator repo and covered there.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 79e2cf13-1074-47c0-8308-37e86e34587a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[NumaryBot]

✅ Approve — automated review

The OpenTelemetry monitoring wiring for the delegated Connectivity resource looks correct. The previously identified major issue — the pod-name=$(POD_NAME) attribute being forwarded verbatim without a downward-API environment variable defined — has been addressed in this revision by filtering out unresolved placeholder attributes before they reach the delegated workload's spec. No new discrete correctness issues were raised by the independent review. The change is ready to merge.

No findings.

[NumaryBot]

NumaryBot posted 1 new inline finding.

Summary: #500 (comment)

[NumaryBot]

NumaryBot posted 1 new inline finding.

Summary: #500 (comment)

[NumaryBot]

NumaryBot review complete: no remaining inline findings.

Resolved 1 stale NumaryBot review thread (0 fixed, 1 outdated).

Summary: #500 (comment)