feat(events): add reconciliation alert events - #2000
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR adds schema tests for eight reconciliation alert events. It also updates event generation to use stable paths and write aggregated data to current and legacy output locations. ChangesEvent compatibility
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Approve — automated reviewThe PR adds table-driven schema tests for eight reconciliation alert event types and updates the event generator to serialize aggregated data once and write it to both current and legacy output paths. All reviewers found no correctness issues with the schemas, catalog updates, or generator changes. No findings warrant blocking or further action. No findings. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@events/index.js`:
- Around line 28-33: Update the catalogue generation writes in the events module
so both generated/all.json and the legacy libs/events/generated/all.json resolve
from the events module root rather than process.cwd(). Use stable root-relative
paths for directory creation and file writes while preserving the existing
aggregatedJSON output.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f108face-ad08-4cbd-bc94-a3e3ebe86484
⛔ Files ignored due to path filters (18)
events/generated/all.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/ACCEPTED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/ACKNOWLEDGED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/OPENED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/REOPENED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/RESOLVED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/SNOOZED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/UNSNOOZED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/generated/reconciliation/v2.4.0/UPDATED_ALERT.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**events/services/reconciliation/v2.4.0/ACCEPTED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/ACKNOWLEDGED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/OPENED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/REOPENED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/RESOLVED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/SNOOZED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/UNSNOOZED_ALERT.yamlis excluded by!**/*.yamlevents/services/reconciliation/v2.4.0/UPDATED_ALERT.yamlis excluded by!**/*.yamllibs/events/generated/all.jsonis excluded by!**/generated/**,!**/*.json,!**/generated/**
📒 Files selected for processing (2)
events/events_test.goevents/index.js
Summary
OPENED_ALERT,RESOLVED_ALERT, etc.)Impact
Webhook event catalogues can expose the new
reconciliation.*_alertsubscriptions with payload schemas matching the Reconciliation alert and alert-event models.Validation
cd events && go test ./...node index.jsgit diff --check