fix(openapi): preserve typed default errors - #2002
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
WalkthroughThe ChangesOpenAPI validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Approve — automated reviewThe change consistently limits the global Speakeasy error policy to No findings. |
Summary
defaultonly4XX/5XXmatchers from shadowing typed default error schemas in generated SDKsRoot cause
The
4XXand5XXmatchers introduced in v3.2.9 run before each operation's typeddefaulterror response in generated SDKs. Structured API errors are therefore converted into generic SDK errors, and explicit error statuses can disappear from generated response models.Validation
nix develop --impure --command bash -c 'just generate-composition-overlay && speakeasy run -s all --skip-upload-spec --auto-yes && just validate-openapi'["default"]paths.x-speakeasy-errors(ac36525febc56af5e96654b57a70824625137631053f19c71481375364681b3e)git diff --checkRelease
This is intended for Stack v3.2.10. SDKs should regenerate from the v3.2.10 Registry revision before any generated PR is merged.