F-022: extract validation framework into plugins/core - #165
Merged
Conversation
Move TargetValidator SPI, identity-cached factories, ContentRule predicates, and FormaValidationException into tools.forma.core.validation. Keep tools.forma.validation as a thin facade (ProjectValidationError parity) and wire Android content helpers to pure core rules. Sample + plugins builds green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TargetValidatorSPI, identity-cacheddependencyTypeValidator/selfTypeValidator, pureContentRulepredicates, andFormaValidationExceptionintoplugins/core(tools.forma.core.validation).tools.forma.validationas a Gradle-compatible facade over core (still throwsProjectValidationError; F-017 cache preserved).FormaTargetimplements coreTargetRef; AndroidcommonValidatorscall pure content rules with Gradle FS listing.Ticket
F-022 — Extract validation framework into forma-core (Android helpers stay platform-owned).
Verify
plugins/:./gradlew :core:test→ BUILD SUCCESSFULplugins/:./gradlew build→ BUILD SUCCESSFUL (68 tasks)application/:./gradlew :binary:assembleDebug→ BUILD SUCCESSFUL (578 tasks)Out of scope
F-023 registry/DSL migration; F-024 coordinates.