Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][FormTribe 🔥][100 Points] Are you Sure modal Missing #1419

Closed
2 tasks done
ShubhamPalriwala opened this issue Oct 23, 2023 · 11 comments
Closed
2 tasks done

[BUG][FormTribe 🔥][100 Points] Are you Sure modal Missing #1419

ShubhamPalriwala opened this issue Oct 23, 2023 · 11 comments
Assignees
@RajuGangitla
Labels
bug Something isn't working formtribe-2023 Issues related to Formtribe 2023 hackathon hacktoberfest complete these issues to gather points for Hacktoberfest

Comments

@ShubhamPalriwala
Copy link
Contributor

Issue Summary

Whenever a user made changes to a survey and the clicked on the Back button, we'd send them a modal popover confirming if they want to Discard their changes or save them. Looks like our modal is lost somewhere now haha! Please see the attached video that reproduces the bug.

Steps to Reproduce

  1. Create any survey
  2. Publish it
  3. Now Edit the Survey (make 1+ changes)
  4. Now click on the Back Button
  5. You will be taken back with your changes discarded

Expected behavior

Before Step 5 above, the user should be popped with a confirmation Are you Sure message

Other information

No response

Screenshots

https://tella.video/are-you-sure-modal-missing-18o5

Environment

  • Formbricks Cloud (app.formbricks.com)
  • Self-hosted Formbricks

Desktop (please complete the following information)

- OS:
- Node:
- npm:
@ShubhamPalriwala ShubhamPalriwala added bug Something isn't working hacktoberfest complete these issues to gather points for Hacktoberfest formtribe-2023 Issues related to Formtribe 2023 hackathon labels Oct 23, 2023
@adityadeshlahre
Copy link
Contributor

i would like to take this ! 😄

@RajuGangitla
Copy link
Contributor

can u assign this to me

@ShubhamPalriwala
Copy link
Contributor Author

Yours @adityadeshlahre for the next 24 hours atleast!

@SumanKisku
Copy link
Contributor

I would like to work on this too

1 similar comment
@venk404
Copy link

venk404 commented Oct 23, 2023

I would like to work on this too

@muhammed-mukthar
Copy link

@ShubhamPalriwala I would want to work on this

@adityadeshlahre
Copy link
Contributor

Hey @ShubhamPalriwala
thank you for previous 24 hours to solve this issue
Maybe i am over-complicating things i am sure other contributers
will present more optimal solution i will dive into code more thoroughly
Thank You 😄

@RajuGangitla is next in a row !
you can start working on this issue.

@RajuGangitla
Copy link
Contributor

RajuGangitla commented Oct 24, 2023 •
edited
Loading

@ShubhamPalriwala now it's my turn can u assign this issue to me

@ShubhamPalriwala
Copy link
Contributor Author

Thanks! Over to you now

This was referenced Oct 25, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 6, 2023
@RajuGangitla @mattinannt
are you sure modal missing fix:#1419 (#1485)
5ea1588 
Co-authored-by: Matti Nannt <mail@matthiasnannt.com>
kevinkong91 added a commit to kevinkong91/formbricks that referenced this issue Nov 7, 2023
@kevinkong91
Merge branch 'main' into dev
af2adeb 
* main: (42 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
kevinkong91 added a commit to kevinkong91/formbricks that referenced this issue Nov 7, 2023
@kevinkong91
Merge branch 'main' into build-from-source
1698177 
* main: (70 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
@karthiknadar1204
Copy link

@ShubhamPalriwala of this issue is not resolved yet,i would like to work on it

@ShubhamPalriwala
Copy link
Contributor Author

This has been fixed! Apologies for not closing this earlier :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RajuGangitla RajuGangitla

Labels
bug Something isn't working formtribe-2023 Issues related to Formtribe 2023 hackathon hacktoberfest complete these issues to gather points for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@SumanKisku @ShubhamPalriwala @venk404 @muhammed-mukthar @karthiknadar1204 @RajuGangitla @adityadeshlahre