fix: openText issue

[Dhruwang]

What does this PR do?

Fixes a bug where input fields are filled automatically for open text questions when long answer is off

Screen.Recording.2023-11-06.at.10.27.11.AM.mov

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

How should this be tested?

Create consecutive short answer open text questions
Fill one question
Check others

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)		Nov 6, 2023 5:00am
formbricks-com	⬜️ Ignored (Inspect)		Nov 6, 2023 5:00am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/surveys/src/components/OpenTextQuestion.tsx

The code modification ensures that the input field's value is not null or undefined. This is a good practice as it prevents potential issues that could arise from assigning null or undefined to the input field's value. However, the same modification is not applied to the textarea field. It would be beneficial to apply this modification to the textarea field as well to maintain consistency and prevent potential issues.
Create Issue

    <textarea
      ref={openTextRef}
      rows={3}
      name={question.id}
      tabIndex={1}
      id={question.id}
      placeholder={question.placeholder}
      required={question.required}
      value={value ? (value as string) : ""}
      type={question.inputType}
      onInput={(e) => handleInputChange(e.currentTarget.value)}
      autoFocus={autoFocus}
      pattern={question.inputType === "phone" ? "[+][0-9 ]+" : ".*"}
      title={question.inputType === "phone" ? "Please enter a valid phone number" : undefined}
      className={`block w-full rounded-md border
      border-slate-100
      bg-slate-50 p-2 shadow-sm focus:border-slate-500 focus:outline-none focus:ring-0 sm:text-sm`}></textarea>

The current implementation submits the form when the Enter key is pressed. This could lead to accidental form submissions if the user presses the Enter key unintentionally. It would be better to prevent form submission on pressing the Enter key and instead provide a clear call to action for the user to submit the form.
Create Issue

    <input
      ref={openTextRef}
      tabIndex={1}
      name={question.id}
      id={question.id}
      placeholder={question.placeholder}
      required={question.required}
      value={value ? (value as string) : ""}
      type={question.inputType}
      onInput={(e) => handleInputChange(e.currentTarget.value)}
      autoFocus={autoFocus}
      onKeyDown={(e) => {
        if (e.key == "Enter") e.preventDefault();
      }}
      pattern={question.inputType === "phone" ? "[+][0-9 ]+" : ".*"}
      title={question.inputType === "phone" ? "Enter a valid phone number" : undefined}
      className={`block w-full rounded-md border
      border-slate-100
      bg-slate-50 p-2 shadow-sm focus:border-slate-500 focus:outline-none focus:ring-0 sm:text-sm`}
    />

[mattinannt]

💪🙏