fix: editor crashing

[Dhruwang]

What does this PR do?

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

How should this be tested?

• Test A
• Test B

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)		Nov 6, 2023 10:31am
formbricks-com	⬜️ Ignored (Inspect)		Nov 6, 2023 10:31am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

packages/surveys/src/components/ProgressBar.tsx

The calculateProgress function is quite complex and could be refactored for better readability and performance. Instead of using the findIndex method twice, you can use it once and store the result in a variable. Also, the getLastQuestionIndex function can be simplified by using the findLastIndex method.
Create Issue

    function calculateProgress(questionId: string, survey: TSurveyWithTriggers, progress: number) {
      if (survey.questions.length === 0) return 0;
      if (questionId === "end") return 1;

      let currentQuestionIdx = survey.questions.findIndex((e) => e.id === questionId);
      if (progress > 0 && currentQuestionIdx === prevQuestionIdx) return progress;
      if (currentQuestionIdx === -1) currentQuestionIdx = 0;
      const currentQuestion = survey.questions[currentQuestionIdx];
      const surveyLength = survey.questions.length;
      const middleIdx = Math.floor(surveyLength / 2);
      const possibleNextQuestions = currentQuestion.logic?.map((l) => l.destination) || [];

      const getLastQuestionIndex = () => {
        return survey.questions.findLastIndex((q) => possibleNextQuestions.includes(q.id));
      };

      let elementIdx = currentQuestionIdx || 0.5;
      const lastQuestionIdx = getLastQuestionIndex();

      if (lastQuestionIdx > 0) elementIdx = Math.min(middleIdx, lastQuestionIdx - 1);
      if (possibleNextQuestions.includes("end")) elementIdx = middleIdx;

      const newProgress = elementIdx / survey.questions.length;

      // Determine if user went backwards in the survey
      const didUserGoBackwards = currentQuestionIdx < prevQuestionIdx;

      // Update the progress array based on user's navigation
      let updatedProgress = progress;
      if (didUserGoBackwards) {
        updatedProgress = progress - (prevQuestionIdx - currentQuestionIdx) * PROGRESS_INCREMENT;
      } else if (newProgress > progress) {
        updatedProgress = newProgress;
      } else if (newProgress <= progress && progress + PROGRESS_INCREMENT <= 1) {
        updatedProgress = progress + PROGRESS_INCREMENT;
      }

      setPrevQuestionIdx(currentQuestionIdx);
      return updatedProgress;
    }