Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add scroll to the setting navbar #1398

Merged
merged 4 commits into from
Nov 6, 2023
Merged

fix: Add scroll to the setting navbar #1398

merged 4 commits into from
Nov 6, 2023

Conversation

NilanjanPramanik
Copy link
Contributor

What does this PR do?

This PR added scroll to the setting navbar

Fixes #1190

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 22, 2023

@NilanjanPramanik is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added bug Something isn't working formtribe-2023 Issues related to Formtribe 2023 hackathon hacktoberfest complete these issues to gather points for Hacktoberfest labels Oct 22, 2023
@review-agent-prime
Copy link
Contributor

The changes in the PR seem to be adding scroll functionality to certain div elements. While this is a good approach to handle overflow of content, it might be better to consider a responsive design that adjusts the layout based on the screen size. This would provide a better user experience as it avoids the need for scrolling.

However, if scrolling is necessary, it's recommended to use overflow-auto instead of overflow-scroll. The overflow-auto property will only show the scrollbar when necessary (i.e., when the content overflows), whereas overflow-scroll will always show the scrollbar even if it's not needed.

Here are the suggested changes:

-      <div className="fixed hidden h-full overflow-y-scroll bg-white py-2 pl-4 pr-10 md:block ">
+      <div className="fixed hidden h-full overflow-y-auto bg-white py-2 pl-4 pr-10 md:block ">

-      <div className="fixed z-10 flex h-14 overflow-x-scroll w-full items-center justify-between border-b border-slate-200 bg-white px-4 sm:px-6 md:hidden">
+      <div className="fixed z-10 flex h-14 overflow-x-auto w-full items-center justify-between border-b border-slate-200 bg-white px-4 sm:px-6 md:hidden">

Please consider these changes and let me know if you have any questions or concerns.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

neilchauhan2
neilchauhan2 suggested changes Oct 23, 2023
View reviewed changes
apps/web/app/(app)/environments/[environmentId]/settings/components/SettingsNavbar.tsx Outdated
Comment on lines 193 to 195
return (
<>
<div className="fixed hidden h-full bg-white py-2 pl-4 pr-10 md:block ">
<div className="fixed hidden h-full overflow-y-scroll bg-white py-2 pl-4 pr-10 md:block ">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thank you for your contribution 🎉 , tried testing this on a 13" Mac but still the issue isn't resolved. Even on 100% zoom level not able to view the License link in the Compliance section. Attaching both 100% and 90% views. Can you please fix this, will re-review it once you are done with the fix.

Screenshot 2023-10-23 at 5 59 00 PM Screenshot 2023-10-23 at 5 58 46 PM

cc: @mattinannt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neilchauhan2 yes, you are right. Unfortunately the contributor hasn't answered and I would like to merge this issue to complete the hackathon. Can you please approve the PR? :-)

mattinannt
mattinannt approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :-) the scroll itself is solved; unfortunately the last item is still not visible on small screens. But we can tackle this in a next PR.

@mattinannt mattinannt changed the title [Fix] Add scroll to the setting navbar fix: Add scroll to the setting navbar Oct 30, 2023
@mattinannt mattinannt self-assigned this Nov 6, 2023
@mattinannt mattinannt added this pull request to the merge queue Nov 6, 2023
Merged via the queue into formbricks:main with commit f2d23d9 Nov 6, 2023
7 of 9 checks passed
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
@kevinkong91
Merge branch 'main' into dev
af2adeb 
* main: (42 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
@kevinkong91
Merge branch 'main' into build-from-source
1698177 
* main: (70 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

@neilchauhan2 neilchauhan2 neilchauhan2 approved these changes

Assignees

@mattinannt mattinannt

Labels
bug Something isn't working formtribe-2023 Issues related to Formtribe 2023 hackathon hacktoberfest complete these issues to gather points for Hacktoberfest
Projects
None yet
Milestone
No milestone
3 participants
@NilanjanPramanik @mattinannt @neilchauhan2