Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed URL example for "Create Survey" API endpoint is wrong #1555 #1586

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix: fixed URL example for "Create Survey" API endpoint is wrong #1555 #1586

merged 1 commit into from
Nov 6, 2023

Conversation

shashankshet
Copy link
Contributor

What does this PR do?

Fixes #1555

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

verify the update in https://formbricks.com/docs/api/management/surveys#create-survey
Create survey section curl command should contain POST instead of DELETE

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Copy link

vercel bot commented Nov 6, 2023

@shashankshet is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Thank you for following the naming conventions for pull request titles! 馃檹

@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2023
Copy link
Contributor

page.mdx

It's a good practice to avoid hardcoding sensitive data such as API keys in the code. Instead, you can use environment variables to store such data. This way, you can avoid exposing sensitive data in your codebase.
Create Issue

    curl -X POST \
    'https://app.formbricks.com/api/v1/management/surveys' \
    --header \
    'x-api-key: $YOUR_API_KEY'

It's a good practice to use consistent formatting in your code. In this case, you can improve the readability of your code by using consistent line breaks in your cURL command.
Create Issue

    curl -X POST \
    'https://app.formbricks.com/api/v1/management/surveys/' \
    --header 'Content-Type: application/json' \

@shashankshet shashankshet changed the title fixed URL example for "Create Survey" API endpoint is wrong #1555 fix: fixed URL example for "Create Survey" API endpoint is wrong #1555 Nov 6, 2023
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shashankshet thank you for the fix :-)

@mattinannt mattinannt added this pull request to the merge queue Nov 6, 2023
Merged via the queue into formbricks:main with commit 72fb1b3 Nov 6, 2023
8 of 11 checks passed
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
* main: (42 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
* main: (70 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cURL example for "Create Survey" API endpoint is wrong
2 participants