fix: avoid blocking the request if it does not have an associated ip

[ShubhamPalriwala]

What does this PR do?

Disables the blocking of a request if it does not have an IP address associated with it. This is possible when running it in docker and accessing it from the same network

Fixes #1533

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

How should this be tested?

Run docker compose --env /dev/null up to test it with a newly built image

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Oct 31, 2023 2:30pm
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		Oct 31, 2023 2:30pm

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

The PR removes the else block that sends a response when the IP address is not found. This could potentially lead to issues if the IP address is not found in the request headers.

I suggest adding a response for the case when the IP address is not found. This will ensure that the server sends a response in all cases.

Here is a code suggestion:

if (ip) {
  try {
    if (request.nextUrl.pathname === "/api/auth/callback/credentials") {
      await loginLimiter.check(ip);
    } else if (request.nextUrl.pathname === "/api/v1/users") {
      await signUpLimiter.check(ip);
    }
    return res;
  } catch (_e) {
    console.log("Rate Limiting IP: ", ip);

    return NextResponse.json({ error: "Too many requests, Please try after a while!" }, { status: 429 });
  }
} else {
  console.log("IP address not found in the request headers");
  return NextResponse.json({ error: "IP address not found, Please check your request!" }, { status: 400 });
}

This code will log a message and send a response with a 400 status code when the IP address is not found. This will help in debugging and also inform the client that the request was malformed.