Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github linting issues #1510

Merged
merged 3 commits into from
Nov 6, 2023
Merged

fix: github linting issues #1510

merged 3 commits into from
Nov 6, 2023

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes FOR-1342

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Check review code section of this PR

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 9:03am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2023 9:03am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

In the OpenTextQuestion.tsx file, you've added autoFocus as a dependency to the useCallback hook for openTextRef. This is a good practice as it ensures that the callback is updated whenever autoFocus changes.

In the ProgressBar.tsx file, you've updated the setProgress function to use a function argument, which is a good practice as it ensures that the latest state is used when updating the state. You've also added a condition to only update prevQuestionIdx if currentQustionIdx is different from prevQuestionIdx, which is a good optimization.

In the SubmitButton.tsx file, you've added focus as a dependency to the useCallback hook for buttonRef. This is a good practice as it ensures that the callback is updated whenever focus changes.

In the Survey.tsx file, you've added an eslint disable comment for react-hooks/exhaustive-deps. While this can be necessary in some cases, it's generally recommended to include all dependencies to avoid potential bugs. If there's a specific reason for excluding some dependencies, it would be good to add a comment explaining why.

Overall, the changes in this PR look good. The code is clean and follows best practices. Good job!

@Dhruwang Dhruwang marked this pull request as draft October 30, 2023 05:52
@Dhruwang Dhruwang marked this pull request as ready for review November 3, 2023 09:04
mattinannt
mattinannt approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🙏

@mattinannt mattinannt added this pull request to the merge queue Nov 6, 2023
@mattinannt mattinannt self-assigned this Nov 6, 2023
Merged via the queue into main with commit e0fe7f1 Nov 6, 2023
12 checks passed
@mattinannt mattinannt deleted the github-linting-issues branch November 6, 2023 09:45
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
@kevinkong91
Merge branch 'main' into dev
af2adeb 
* main: (42 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Nov 7, 2023
@kevinkong91
Merge branch 'main' into build-from-source
1698177 
* main: (70 commits)
  chore: add revert to oss-friends (formbricks#745)
  fix: pass authOptions to getServerSession in authLayout (formbricks#1584)
  fix: fixed URL example for "Create Survey" API endpoint is wrong formbricks#1555 (formbricks#1586)
  fix(docs): default account info docs changes (formbricks#1583)
  chore: Add docker packages to Github Packages on release (formbricks#1585)
  feat: avatar upload (formbricks#1546)
  fix: editor crashing (formbricks#1582)
  fix: Add scroll to the setting navbar  (formbricks#1398)
  are you sure modal missing fix:formbricks#1419 (formbricks#1485)
  fix: github linting issues (formbricks#1510)
  refactor: added authorization to airtable integration and create a common actions file (formbricks#1538)
  docs: add docs for airtable (formbricks#1541)
  fix: missing static generation store in revalidation due to pages dir (formbricks#1581)
  feat: Pagination for other values in multi choice (formbricks#1560)
  feat:  $199 pricing model for unlimited plans (formbricks#1564)
  fix: make pricing pages consistent (formbricks#1567)
  fix: openText issue (formbricks#1579)
  fix: avoid blocking the request if it does not have an associated ip (formbricks#1540)
  feat: Add Unkey to OSS Friends (formbricks#1574)
  feat: FOR-683 Role Switch (formbricks#1450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees

@mattinannt mattinannt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dhruwang @mattinannt