are you sure modal missing fix:#1419

[RajuGangitla]

What does this PR do?

Now, if we add or delete question or we made any changes in survey it will show the "are you sure" popup

Fixes # (issue)
#1419

Your.Surveys._.Formbricks.-.Google.Chrome.2023-10-28.10-02-07.mp4

Type of change

• [x ] Bug fix (non-breaking change which fixes an issue)

[vercel]

@RajuGangitla is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "are you sure modal missing fix:#1419". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[review-agent-prime]

The change you made in the useEffect hook, where you deep clone the survey object using JSON.parse(JSON.stringify(survey)), can be a potential performance issue if the survey object is large. This is because JSON.stringify will convert the entire object into a string, and JSON.parse will parse the string back into an object. This operation can be costly for large objects.

If you need to create a deep copy of the survey object to avoid mutating the original object, consider using a library like lodash's _.cloneDeep method which is more efficient for this purpose.

Here's how you can do it:

import _ from 'lodash';

// ...

useEffect(() => {
  if (survey) {
    setLocalSurvey(_.cloneDeep(survey));
    if (survey.questions.length > 0) {
      setActiveQuestionId(survey.questions[0].id);
    }
  }
}, [survey]);

This will create a deep copy of the survey object without the potential performance issue of JSON.parse(JSON.stringify(survey)).

[jobenjada]

@RajuGangitla Please explain how your solution is supposed to work 🤔

[RajuGangitla]

@jobenjada previously when we were trying to edit the survey there if we add or delete some questions and click on back button it's not showing are you sure modal popup is not showing.
Now we can overcome this by creating a deep copy of surveyb object from db and assign it to local survey state this can be done by two ways mentioned below

1. using lodash
2. using json stringify
   @mattinannt suggested that its better if we do without any package and he suggested the 2nd approach and made a pull request with that approach

[mattinannt]

💪🙏