refactor: added authorization to airtable integration and create a common actions file

[Dhruwang]

What does this PR do?

Fixes 1465

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Chore (refactoring code, technical debt, workflow improvements)
• Enhancement (small improvements)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change adds a new database migration
• This change requires a documentation update

How should this be tested?

• Test A
• Test B

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)		Oct 31, 2023 9:28am
formbricks-com	⬜️ Ignored (Inspect)		Oct 31, 2023 9:28am

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[review-agent-prime]

The changes in this PR seem to be focused on refactoring the code to improve modularity and reusability. The actions related to integrations (create, update, delete) have been moved to a common file, which is a good practice. However, there are a few suggestions to improve the code:

1. In the createOrUpdateIntegrationAction and deleteIntegrationAction functions, you are directly returning the result of the createOrUpdateIntegration and deleteIntegration functions. You can remove the await keyword and return the promise directly. This will make your code more efficient as it won't have to wait for the promise to resolve before returning.

export function createOrUpdateIntegrationAction(
  environmentId: string,
  integrationData: TIntegrationInput
) {
  return createOrUpdateIntegration(environmentId, integrationData);
}

export function deleteIntegrationAction(integrationId: string) {
  const session = getServerSession(authOptions);
  if (!session) throw new AuthorizationError("Not authorized");

  const isAuthorized = canUserAccessIntegration(session.user.id, integrationId);
  if (!isAuthorized) throw new AuthorizationError("Not authorized");

  return deleteIntegration(integrationId);
}

2. In the AddIntegrationModal.tsx file, you are using useState to manage the tables state. However, it seems like you are only using setTables in the handleTable function. If tables is not used anywhere else, you might consider moving the useState call into the handleTable function to limit its scope.

3. In the Home.tsx file, you are importing deleteIntegrationAction from the common actions file. Make sure that this function is correctly handling the deletion of Google Sheets integrations, as it was previously imported from the Google Sheets specific actions file.

4. In the refreshSheetAction function, you are throwing an AuthorizationError if the user does not have access to the environment. It would be helpful to include the environmentId in the error message to make debugging easier.

if (!isAuthorized) throw new AuthorizationError(`Not authorized to access environment: ${environmentId}`);

Overall, the changes in this PR are a step in the right direction for improving the modularity and reusability of your code.

[mattinannt]

💪🙏