Skip to content

Conversation

@manuelroth
Copy link

This PR correct the ES Module exports in package.json

@travist
Copy link
Member

travist commented Aug 13, 2024

I actually agree with this change, but us using "cjs" for "import" was changed deliberately. Using mjs was causing some downstream issues with our build process and was not working with applications using legacy versions. Maybe pulling in your other pull request will resolve that issue, so we will give it a try and see what happens downstream due to these changes.

@manuelroth
Copy link
Author

I think its also important to define the type and module properties. See 4113097. This way bundlers will know which entrypoint to use for CommonJS and ES Module.

@manuelroth
Copy link
Author

Hi @travist , were you able to test the changes downstream?- We still have to keep the workaround described in #5735 (comment) in place. I would be glad if we could remove it at some point. Therefore it would be great to know if you have made an progress on this issue. Kind regards, Manuel

@manuelroth
Copy link
Author

Hi @travist, we are trying to upgrade from formiojs to @formio/js (v4 -> v5). The issue described above still persists. The workaround described here: #5735 (comment) doesn't work anymore with v5. Therefore we are now stuck with v4 and can't upgrade to v5 until this issue is resolved. Could you please look into this?

@travist
Copy link
Member

travist commented May 16, 2025

Hello @manuelroth we will escalate this internally to see if we can reach some form of resolution.... thanks.

@manuelroth
Copy link
Author

We were able to find the real cause of the issue. See #5735 for more details. I will close this PR

@manuelroth manuelroth closed this Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants