FIO-9902-9878: fixed an issue where PDF is not loaded for the form with hidden/conditionally hidden select #6074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th hidden/conditionally hidden select
brendanbond
approved these changes
Apr 2, 2025
brendanbond
deleted the
FIO-9902-9878-ficed-pdf-download-for-hidden-select
branch
lane-formio
pushed a commit
that referenced
this pull request
Apr 11, 2025
…-for-hidden-select FIO-9902-9878: fixed an issue where PDF is not loaded for the form with hidden/conditionally hidden select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-9902
https://formio.atlassian.net/browse/FIO-9878
Description
What changed?
When the formio-viewer renders submission on the pdf-server, it waits until dataReady is resolved. But the dataReady is not resolved for list components when they are hidden that courses the PDF not to be generated. This PR fixes it.
Why have you chosen this solution?
Use this section to justify your choices
Breaking Changes / Backwards Compatibility
Use this section to describe any potentially breaking changes this PR introduces or any effects this PR might have on backwards compatibility
Dependencies
https://github.com/formio/premium/pull/389
How has this PR been tested?
manually + tests
Checklist: