Skip to content

Conversation

@roma-formio
Copy link
Contributor

@roma-formio roma-formio commented Apr 22, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9969

Description

Issue: The getRow method is intended to return raw data for conditionals. However, it currently uses localDataPath, which contains indices. As a result, it creates an object similar to data but with empty slots. Additionally, the simple conditional check only verifies a single-level parent to locate the data grid. This approach fails when there is a container inside the data grid, as the data grid cannot be detected.

Solution:

  • Replace localDataPath with localPath to ensure the correct row structure is created.
  • Implement a recursive check for the component's parent to detect the data grid at any level.

How has this PR been tested?

Unit testing

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit ff5653b into master Jun 11, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants