Skip to content

FIO-10200: fix conditionals checking after form submitting#6147

Merged
brendanbond merged 1 commit intomasterfrom
FIO-10200-conditionals-after-submitting
May 29, 2025
Merged

FIO-10200: fix conditionals checking after form submitting#6147
brendanbond merged 1 commit intomasterfrom
FIO-10200-conditionals-after-submitting

Conversation

@Maria-Golomb
Copy link
Copy Markdown
Contributor

@Maria-Golomb Maria-Golomb commented May 29, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10200

Description

After submitting a form, the noCheck flag is set to true. When flags.noCheck is true, the Component checkData method exits early without performing checks.

Previously, the method:

  1. Checked this.checkingData.
  2. Set this.checkingData = true.
  3. Checked flags.noCheck.
  4. Exited the method.
    This caused this.checkingData to remain true, blocking data checking.
    After fix, this.checkingData is updated only when the check is executed, what prevent it from getting stuck.

Breaking Changes / Backwards Compatibility

Dependencies

How has this PR been tested?

manually
autotests

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@brendanbond brendanbond merged commit 65f4e3c into master May 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants