Few issues after 3.0.0 upgrade

[pegaspar]

Hi Ben,

after upgrading to 3.0.0, I have come across these issues:

1. Smarty {php} support not available - I have few email content templates that need to generate an attachment (PDF doc) before they send email. I was using {php} for that. I know it os not the way to do it in Smarty, but I'm afraid, I have no other option in FormTools. For now, I have rewritten all Smarty occurences in the Core to SmartyBC and it works. Maybe it woudl be useful for others to have this as configurable option?
2. email template gets parsed for {attachment} before Smarty evaluates the template - With the use case of generating attachment in the template before sending an email, the file is not existing before the template is processed, so the attachment is not included in the email. The PDF file is created though, but only after attachments have been processed.
3. RadioButton, Dropdown and Date fields don't render for view, unless they are switched to Smarty rendering. The Core PHP rendering functions return blank output.

Hope this information helps.

Thank you,
Peter

[benkeen]

Hey @pegaspar, thanks for this! I'll get back to you tonight.

[benkeen]

Hey Peter,

Sorry you ran into problems, but I'm glad you raised them. Regarding the SmartyBC change, was that just it? You simply switched out the Smarty instances for SmartyBC, or were there any other changes you needed to do? If the latter, if you fancy putting in a PR I could take a look at your fix. But yes, I'm definitely amenable to making this configurable. As it stands the Custom Fields module won't work properly without {php} running (I assume you're using that module?) so that needs to be patched. Perhaps just a new setting in the config.php file is the best approach.

For the second and third issues, I'll take a look. This was working in FT2?

Ben

[pegaspar]

Hi Ben,

I simply switched all instances to SmartyBC. No other change was needed. I have done the changes in Core only, I haven't looked into Custom Fields although I use the module. But I see, there are no instances in the module.

A setting in config.php would be great.

Thanks for your support.
Peter

[benkeen]

This'll take a little time to play around with, but I should get it into 3.0.1. However, I wasn't able to reproduce your second issue with regard to the {$attachment} not getting added to the email - it's woking just fine for me. Could you post the exact Smarty markup you're adding to your email template? I was adding {$attachment field="filefield"} (where "filefield" is the field name of the file field in my form. I added it to my HTML email content.

[pegaspar]

Thanks Ben.

Here is a shortened version of what I try to do in the eMail content template:

{php}

$g_root_dir='/home/.sites/60/site994/web/formtools';

require ($g_root_dir.'/global/scripts/fpdf17/fpdf.php');

$pdf_file_relative_path=$_smarty_tpl->get_template_vars('ANSWER_contract');
$pdf_file_path=$g_root_dir."/".$pdf_file_relative_path;

$subid=$_smarty_tpl->get_template_vars('SUBMISSIONID');
$php_fields=$_smarty_tpl->get_template_vars('fields');
$submissiondate=$_smarty_tpl->get_template_vars('SUBMISSIONDATE');
$date = date_create($submissiondate);
$date = date_format($date,'d/m/Y');

$pdf = new FPDF();
$pdf->AddFont('LucidaGrande','','lucidagrande.php');
$pdf->AddPage();

$pdf->SetY(70);
$pdf->SetLeftMargin(20);
$pdf->SetFont('LucidaGrande','',18);
$pdf->Cell(170,7,utf8_decode("Datenblatt / Auftragsbestätigung"));

$pdf->Output($pdf_file_path);

{/php}

{$attachment fieldvalue="ANSWER_contract"}

<center>
  eMail Text here
</center>

BTW, the statement "global $g_root_dir" didn't work either in this version. I had to explicitly define the root directory. Also, I had to change to the $_smarty_tpl object instead of using $this to get the variables into the {php} section.

[benkeen]

Hey @pegaspar,

The first and third issues in your original post have been patched and will be in 3.0.1, which I'll release tonight. Note: after upgrading, add the following line to your /global/config.php to get SmartyBC:

$g_use_smarty_bc = true;

Regarding your second issue, that one still puzzles me: the processing order of the PHP and Smarty content shouldn't have change between FT 2 and 3. It's not just a question of your {$attachment} line? According to the docs the two available formats are:

{$attachment field="file_field1"}
{$attachment file="/folder/myfile.txt"}

https://docs.formtools.org/modules/swift_mailer/file_attachments/

[benkeen]

[Removing the 3.0.1 milestone from this ticket - will add to future milestone if we need a fix for the remaining issue]

[nelsondcosta23]

Hi guys,
There is anyway to do the same for multiupload?