Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented May 21, 2021

Switches $form_id to :form_id in binding

Switches $form_id to :form_id in binding
@ghost
Copy link
Author

ghost commented May 21, 2021

References #783 stack trace

@eharvey71
Copy link

I installed this using Softaculous on Hostgator and was getting "Fatal error: Uncaught PDOException: SQLSTATE[HY093]: Invalid parameter number". Making this correction fixed the issue. When do you think the newest version will get deployed? The version that it installs is 2 years old. Thank you!

@the-ft
Copy link

the-ft commented Jan 18, 2023

really nice project but many little careless misdtakes.
found this too..
views.class.php 911
WHERE v.form_id = $form_id AND
->
WHERE v.form_id = :form_id AND
also
Database.class.php 71
$this->statement = $this->dbh->prepare($query);

which have to be sometimes prepare and sometimes query, a quick and dirty approach would be
->
if (strpos($query, " :")) { $this->statement = $this->dbh->prepare($query); } else { $this->statement = $this->dbh->query($query); }

@benkeen
Copy link
Member

benkeen commented Jan 19, 2023

It's an old project now! I haven't been maintaining it for a few years, but given that people are still using it and it's not compatible with PHP8 I'll take some time in the next few months to add PHP8 support. This fix will get rolled out with the next update. Thanks @rowright!

@benkeen benkeen merged commit c497122 into formtools:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants