Skip to content

[#834] Increase IP address size for IPv6 #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

[#834] Increase IP address size for IPv6 #837

merged 1 commit into from
Jan 19, 2023

Conversation

@tvdhout
Copy link
Contributor

@tvdhout tvdhout commented Feb 1, 2022

Fixes issue #834

@mdavids
Copy link

mdavids commented Feb 2, 2022

It may be worth to set the length to 45 (grep INET6_ADDRSTRLEN /usr/include/arpa/inet.h shows 46, but that is including a terminating '\0'), to also cover the rare cases of IPv6 mapped IPv4 notation (0000:0000:0000:0000:0000:0000:123.123.123.123).

@benkeen benkeen merged commit 5390fed into formtools:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvdhout @mdavids @benkeen