Rename layout to customEncoding; indent JSON examples - #4
Merged
forshtat merged 1 commit intoAug 4, 2026
Conversation
Two mechanical changes, no semantic ones.
1. Rename the `layout` key to `customEncoding` everywhere it refers to the
mechanism: the Specification heading and prose, all JSON examples in the
ERC, the companion JSON Schema (including the `$layout` definition group
and every `#/$layout/...` reference), and the example descriptors under
assets/erc-0000/.
Two occurrences are deliberately left alone: the `title:` frontmatter, and
"an ABI-encoded `array` data layout" under `sequence`, which uses "layout"
as an ordinary English word rather than as the key name.
2. Reformat every JSON block in the ERC, replacing the mix of single-line and
multi-line styles with one consistent rule: any object or array that
contains another object or array is expanded one level per line, while a
flat one holding only scalars stays on a single line if it fits in 100
columns. So nesting is always visible, but short leaf entries such as
{ "path": "to", "label": "To" } are not spread over four lines.
Verified: all 47 `$ref`s in the schema still resolve, all 12 example
descriptors validate against the renamed schema (the pre-rename `layout` key
is rejected by it, so the check is not vacuous), and every JSON block in the
ERC round-trips through a parser unchanged apart from whitespace.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The commit 7ec37e1 (as a parent of a66de8d) contains errors. |
forshtat
merged commit Aug 4, 2026
9eb2316
into
forshtat:ideas-erc7730-non-abi-dispatch
10 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two mechanical changes, no semantic ones.
layouttocustomEncoding— in the ERC, in the companion JSON Schema, and in the example descriptors underassets/erc-0000/.There is a lot of generic naming in the spec "path" "layout" etc. and I appreciate more descriptive naming.
{ "path": "to", "label": "To" }stay on a single line.🤖 Generated with Claude Code