Fix DAST audit eligibility and server tier handling - #1085
Merged
rsenden merged 2 commits intoSep 1, 2026
Conversation
Download the current SSC FPR state so suppression and audit metadata are honored before quota submission. Preserve server-provided DAST tiers through a typed domain model and harden stream result handling.
ankit2995
force-pushed
the
ankit/dast-audit
branch
from
September 1, 2026 09:13
392731d to
9ebb0a2
Compare
ankit2995
marked this pull request as ready for review
September 1, 2026 09:16
rsenden
reviewed
Sep 1, 2026
| private TagMappingConfig.Result getDastResultConfig(AuditResponse response, | ||
| TagMappingConfig tagMappingConfig) { | ||
| boolean tierOne = "GOLD".equalsIgnoreCase(response.getTier()); | ||
| boolean tierOne = AuditTier.GOLD.name().equals(response.getTier()); |
Contributor
There was a problem hiding this comment.
Why not use AuditTier::fromServerValue (or extra method on AuditTier to differentiate between case-sensitive/insensitive matching if needed)
Contributor
Author
There was a problem hiding this comment.
Thanks @rsenden I’ve updated both DAST string boundaries to use AuditTier.fromServerValue(...). This preserves case-insensitive matching and defaults null or unknown tiers to SILVER.
rsenden
merged commit Sep 1, 2026
70ed7df
into
fortify:feat/v3.x/aviator/26.4
14 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuditTierfor typedGOLD/SILVERhandling.SILVER.