Skip to content

Conversation

@cyberhck
Copy link
Contributor

@cyberhck cyberhck commented Jul 29, 2020

closes #33

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #32 into master will decrease coverage by 12.08%.
The diff coverage is 51.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
- Coverage   91.57%   79.48%   -12.09%     
===========================================
  Files          39       25       -14     
  Lines         451      273      -178     
  Branches       54       33       -21     
===========================================
- Hits          413      217      -196     
- Misses         38       56       +18     
Impacted Files Coverage Δ
src/app/containers/EmptyState.tsx 87.50% <ø> (ø)
src/app/routes/routes.ts 66.66% <0.00%> (+9.52%) ⬆️
src/app/pages/RunsPage.tsx 38.09% <38.09%> (ø)
src/app/pages/HomePage.tsx 58.13% <75.00%> (+3.85%) ⬆️
src/app/components/Card/Card.tsx 85.71% <85.71%> (ø)
src/app/containers/App.tsx 100.00% <100.00%> (ø)
src/app/containers/Header.tsx 80.00% <100.00%> (-20.00%) ⬇️
.../modules/featureRuns/fetchFeatureRunsForFeature.ts 100.00% <100.00%> (ø)
src/app/sagas/BaseSaga.ts
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726c809...b97db60. Read the comment docs.

@cyberhck
Copy link
Contributor Author

todo left: implement a runs page

@todo
Copy link

todo bot commented Jul 29, 2020

find a way to parse date correctly, make sure timezones are handled correctly on backend.

// todo: find a way to parse date correctly, make sure timezones are handled correctly on backend.
this.props.createRun(request);
}
}
const mapStateToProps = (state: Pick<IStore, "featureRuns">): IStateToProps => {


This comment was generated by todo based on a todo comment in b97db60 in #32. cc @fossapps.

@cyberhck cyberhck marked this pull request as ready for review July 29, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature runs

3 participants