Skip to content

spouts/rss/enclosures: Link enclosed audio file - #1574

Merged
jtojnar merged 4 commits into
masterfrom
av-enclosures
Jul 26, 2026
Merged

spouts/rss/enclosures: Link enclosed audio file#1574
jtojnar merged 4 commits into
masterfrom
av-enclosures

Conversation

@jtojnar

@jtojnar jtojnar commented Jul 26, 2026

Copy link
Copy Markdown
Member

This is useful for playing podcasts.

Not embedding audio player for now, as that would require loading on demand to prevent tracking.

See: #1169

jtojnar added 4 commits July 26, 2026 04:47
This will be cleaner when rendering other enclosure types.
Otherwise we would get `Cannot redeclare function` if we used the same function names in other spouts.
This is useful for playing podcasts.

Not embedding audio player for now, as that would require loading on demand to prevent tracking.
@netlify

netlify Bot commented Jul 26, 2026

Copy link
Copy Markdown

Deploy Preview for selfoss canceled.

Name Link
🔨 Latest commit 149a26e
🔍 Latest deploy log https://app.netlify.com/projects/selfoss/deploys/6a658cf91d9f770008737beb

@jtojnar jtojnar added this to the 2.20 milestone Jul 26, 2026
@jtojnar
jtojnar merged commit 149a26e into master Jul 26, 2026
12 checks passed
@jtojnar
jtojnar deleted the av-enclosures branch July 26, 2026 04:36
@otyugh

otyugh commented Jul 26, 2026

Copy link
Copy Markdown

Being impatient made me do a custom Fossar instance :p (I didn't even hope you'd answer, I'm baaad)

I just did this to my selfoss/src/spouts/rss/feed.php, assuming that, if there is an enclosure, that's what we want to load (work for most podcast).

            $enclosure=$item->get_enclosure()->link;
            if(!empty($enclosure)){$link=$enclosure;}else{$link = htmlspecialchars_decode((string) $item->get_link(), ENT_COMPAT);}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants