feat: change bottom bar's inactive title color to grey #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier, all the tab titles were purple in color irrespective of whether the tabs were active or not. So, a color-list resource was made to rectify this. Now, only the active tab's title is purple. Other's are grey(the same color as the tab icons). Fixes: fossasia#1079
liveHarshit
reviewed
Feb 11, 2019
| <selector xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <item android:color="@color/colorPrimary" android:state_selected="true" /> | ||
| <item android:color="@color/lighter_grey" android:state_selected="false" /> | ||
| </selector> |
Member
There was a problem hiding this comment.
I think it can be add to styles.xml.
Contributor
Author
There was a problem hiding this comment.
I put it there because the documentation at developer.android.com said color state list resources should be put in the color directory.
iamareebjamal
approved these changes
Feb 11, 2019
angmas1
pushed a commit
to angmas1/open-event-android
that referenced
this pull request
Feb 13, 2019
Earlier, all the tab titles were purple in color irrespective of whether the tabs were active or not. So, a color-list resource was made to rectify this. Now, only the active tab's title is purple. Other's are grey(the same color as the tab icons). Fixes: fossasia#1079
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1079
Changes: Earlier, all the tab titles were purple in color irrespective of whether
the tabs were active or not.
So, a color-list resource was made to rectify this.
Now, only the active tab's title is purple. Other's are grey(the same
color as the tab icons).
Screenshots for the change:
Current look:
Updated look: