fix : App crash while trying to editing a profile with no profile picture #684

trancenoid · 2018-11-03T16:42:29Z

Fixes #683

Changes: Added code to check if the profile picture URL is not empty, as Picasso requires a non-empty url. Thus if there is no profile picture initially, there should be no attempt to load such an image.

trancenoid · 2018-11-03T17:28:33Z

@iamareebjamal Would you please review my PR?

iamareebjamal · 2018-11-03T17:38:32Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

-                            .placeholder(icon)
-                            .transform(CircleTransform())
-                            .into(rootView.profilePhoto)
+                        if(!imageUrl.equals("")) { // picasso requires the imageUrl to be non empty


Use TextUtils.isEmpty

iamareebjamal · 2018-11-03T17:39:31Z

Follow commit message guidelines

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

trancenoid · 2018-11-03T18:24:57Z

@iamareebjamal Updated, but I think I made another commit which is not advises as per the rules, I dont really know the procedure to amend a commit from a forked repo

iamareebjamal · 2018-11-03T18:29:33Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

                    val drawable = AppCompatResources.getDrawable(ctx, R.drawable.ic_account_circle_grey_24dp)
                    drawable?.let { icon ->
-                        if(!imageUrl.equals("")) { // picasso requires the imageUrl to be non empty
+                        if(!imageUrl.isEmpty()) { // picasso requires the imageUrl to be non empty


It'll fail on null

val userFirstName = it.firstName.nullToEmpty() val userLastName = it.lastName.nullToEmpty() val imageUrl = it.avatarUrl.nullToEmpty() rootView.firstName.setText(userFirstName) rootView.lastName.setText(userLastName) context?.let { ctx -> val drawable = AppCompatResources.getDrawable(ctx, drawable.ic_account_circle_grey_24dp) drawable?.let { icon -> if(!imageUrl.isEmpty()) { // picasso requires the imageUrl to be non empty Picasso.get() .load(imageUrl).....

@iamareebjamal I think val imageUrl = it.avatarUrl.nullToEmpty() will take care of that

OK. So, we can add the if statement even above the context.let

Sure, I will do it

@iamareebjamal Done

iamareebjamal · 2018-11-03T19:20:20Z

Updated, but I think I made another commit which is not advises as per the rules, I dont really know the procedure to amend a commit from a forked repo

Just update the PR title

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal · 2018-11-04T09:43:18Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

+                                .transform(CircleTransform())
+                                .into(rootView.profilePhoto)
+
+                        }


Fix indentation

@iamareebjamal Done!

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

# Conflicts: # app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

iamareebjamal · 2018-11-04T18:01:22Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

-                            .placeholder(icon)
-                            .transform(CircleTransform())
-                            .into(rootView.profilePhoto)
+                if(!imageUrl.isEmpty()) { // picasso requires the imageUrl to be non empty


Space after if

@iamareebjamal Sorry, missed that. I have removed it

Space should be added

@iamareebjamal is it correctly done now ?

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal

Opposite of what I wanted

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal · 2018-11-04T18:56:10Z

app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

+                if (!imageUrl.isEmpty()) { // picasso requires the imageUrl to be non empty
+                    context?.let { ctx ->
+                        val drawable = AppCompatResources.getDrawable(ctx, R.drawable.ic_account_circle_grey_24dp)
+                        drawable?.let{ icon ->


Space after let

@iamareebjamal Done

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal · 2018-11-04T19:49:35Z

OK, now just change the PR title according to the commit guidelines and we are done

trancenoid · 2018-11-05T04:27:03Z

@iamareebjamal I have changed the PR title as requested.

fixes issue fossasia#683

d12f6bd

trancenoid changed the title ~~fixes issue #683~~ fixes issue #683 App crash on trying to edit profile when the user dont have a profile picture Nov 3, 2018

iamareebjamal reviewed Nov 3, 2018

View reviewed changes

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

158125a

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal reviewed Nov 3, 2018

View reviewed changes

trancenoid changed the title ~~fixes issue #683 App crash on trying to edit profile when the user dont have a profile picture~~ Fix : issue #683 : Crash on editing profile with no profile picture Nov 3, 2018

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

31c11ba

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

nikit19 previously approved these changes Nov 4, 2018

View reviewed changes

iamareebjamal requested changes Nov 4, 2018

View reviewed changes

trancenoid added 2 commits November 4, 2018 22:29

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

873ce48

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

Merge remote-tracking branch 'origin/development' into development

a1e9ecb

# Conflicts: # app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt

trancenoid dismissed nikit19’s stale review via a1e9ecb November 4, 2018 17:01

iamareebjamal reviewed Nov 4, 2018

View reviewed changes

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

184741a

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal requested changes Nov 4, 2018

View reviewed changes

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

975b03a

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

iamareebjamal reviewed Nov 4, 2018

View reviewed changes

Fix : issue fossasia#683 : Crash on editing profile with no profile p…

314eea9

…icture This fix addresses the problem which crashed the app when a user with no profile picture tries to edit the profile. The imageUrl must not be an empty string, as required by Picasso.get() method

trancenoid changed the title ~~Fix : issue #683 : Crash on editing profile with no profile picture~~ fix : App crash while trying to editing a profile with no profile picture Nov 5, 2018

iamareebjamal approved these changes Nov 5, 2018

View reviewed changes

iamareebjamal merged commit f489b46 into fossasia:development Nov 5, 2018

fix : App crash while trying to editing a profile with no profile picture #684

fix : App crash while trying to editing a profile with no profile picture #684

Uh oh!

Conversation

trancenoid commented Nov 3, 2018

Uh oh!

trancenoid commented Nov 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Nov 3, 2018

Uh oh!

trancenoid commented Nov 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

trancenoid Nov 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Nov 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Nov 4, 2018

Uh oh!

trancenoid commented Nov 5, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

trancenoid Nov 3, 2018 •

edited

Loading