Skip to content

fix : App crash while trying to editing a profile with no profile picture #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 5, 2018
Merged

fix : App crash while trying to editing a profile with no profile picture #684

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d12f6bd
fixes issue #683
trancenoid Nov 3, 2018
158125a
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 3, 2018
31c11ba
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 3, 2018
873ce48
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 4, 2018
a1e9ecb
Merge remote-tracking branch 'origin/development' into development
trancenoid Nov 4, 2018
184741a
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 4, 2018
975b03a
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 4, 2018
314eea9
Fix : issue #683 : Crash on editing profile with no profile picture
trancenoid Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions app/src/main/java/org/fossasia/openevent/general/auth/EditProfileFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,16 @@ class EditProfileFragment : Fragment() {
val imageUrl = it.avatarUrl.nullToEmpty()
rootView.firstName.setText(userFirstName)
rootView.lastName.setText(userLastName)
context?.let { ctx ->
val drawable = AppCompatResources.getDrawable(ctx, R.drawable.ic_account_circle_grey_24dp)
drawable?.let { icon ->
Picasso.get()
.load(imageUrl)
.placeholder(icon)
.transform(CircleTransform())
.into(rootView.profilePhoto)
if (!imageUrl.isEmpty()) { // picasso requires the imageUrl to be non empty
context?.let { ctx ->
val drawable = AppCompatResources.getDrawable(ctx, R.drawable.ic_account_circle_grey_24dp)
drawable?.let { icon ->
Picasso.get()
.load(imageUrl)
.placeholder(icon)
.transform(CircleTransform())
.into(rootView.profilePhoto)
}
Copy link
Member

@iamareebjamal iamareebjamal Nov 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

Copy link
Member Author

@trancenoid trancenoid Nov 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamareebjamal Done!

}
}
}
Expand Down