Skip to content

Conversation

@jithinbp
Copy link
Collaborator

@jithinbp jithinbp commented Jun 6, 2017

jithinbp added 16 commits April 14, 2017 13:11
 Fixes#58 . Separate methods for starting acquisition, fetching data buffer, and processing data buffer have been implemented in Peripherals.I2C
Fixes fossasia#58 . Separate methods for starting acquisition, fetching data buffer, and processing data buffer have been implemented in Peripherals.I2C
…d on Codacy recommendations

 sciencelab.SPI.xfer created. fixes fossasia#64 . Minor changes to Sensor libraries
@jithinbp jithinbp merged commit fcf6357 into fossasia:development Jun 8, 2017
@mariobehling
Copy link
Member

@jithinbp Please don't merge your own commits. Please ask @CloudyPadmal to review. It is also a chance for everyone to learn more about the project.

It is important that devs follow best practices to give everyone a chance to align.

@jithinbp jithinbp requested a review from CloudyPadmal June 8, 2017 18:28
@jithinbp
Copy link
Collaborator Author

jithinbp commented Jun 8, 2017

@mariobehling Apologies. I'll be including him for future PRs .
I already raised a new PR for a separate issue raised by @viveksb007 , so I don't know if I can undo this though.

REG_SYNC_WORD = 0x39
REG_DIO_MAPPING_1 = 0x40
REG_VERSION = 0x42
REG_PA_DAC = 0x4D
Copy link
Contributor

@CloudyPadmal CloudyPadmal Jun 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignments can be fixed when this file gets edited in future! 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. i'm on it.
You can get the modules on AliExpress for as low as $4 - $5 .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's superb! :D I was checking the device in eBay. There are two types I found SPI and TTL! Current implementation is using SPI only right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the underlying chip is SX1276, this library will work. I've used the 434 MHz modules from Dorji (DRF1276) as well as the RA-02 from AI-thinker. There are 868 MHz versions also, and only the right frequency needs to be selected in the code.

Copy link
Contributor

@CloudyPadmal CloudyPadmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a complete code for LoRa modules using SPI! 👍 Nice work @jithinbp !

@jithinbp
Copy link
Collaborator Author

jithinbp commented Jun 9, 2017

Thanks. Complete enough to manage P2P connectivity , but if you look at the massive documentation, it is actually a highly capable chip with advanced features.
Also, if you want to leverage existing commercial LoRaWAN gateways, one has to implement the entire LoRaWAN stack in Python. The LoRa modules from Microchip that use UART communication, and cost 5 times as much , have the LoRaWAN stack built into the firmware.

@hongquan
Copy link
Member

You work is great. But next time could you please put more effort in coding style?

@jithinbp
Copy link
Collaborator Author

thanks. will do. I try to keep up with Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants