Skip to content

Conversation

@pfreitag pfreitag merged commit 5ce4e27 into foundeo:master Nov 10, 2025
@pfreitag
Copy link
Member

Thanks @acterry our names were better :-) but I agree, we need to match the official ones. Thanks for submitting the update.

@acterry
Copy link
Contributor Author

acterry commented Nov 10, 2025

Thanks for the merge. I'm a fan of named params in the code I write, instead of true/false values that someone has to go look up to verify intent.

So, this one caused a production bug for us.

It was buried in a logic branch that rarely gets executed, but lit up like a Christmas tree recently.

@pfreitag
Copy link
Member

Yeah, it's a good practice. I almost always use them on cfc methods, but I usually don't use them on builtin functions. Something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants