fix(verify): report null-contract errors - #16083
Merged
Merged
Conversation
Sourcify-compatible verifiers can return a null contract alongside a terminal error. Deserialize that response and surface the verifier's error instead of retrying a permanent parse failure. Amp-Thread-ID: https://ampcode.com/threads/T-019fe08c-17fb-7354-9345-1d893b758901 Co-authored-by: Amp <amp@ampcode.com>
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse and
stevencartavia
as code owners
August 8, 2026 09:56
Contributor
✅ Changelog foundThe deterministic check will validate the changed entry. |
figtracer
force-pushed
the
fix/sourcify-null-contract
branch
from
August 8, 2026 10:33
ac6d4c9 to
27331a8
Compare
stevencartavia
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tempo nightly failure in #16075 exposed a valid Sourcify-compatible error response where a completed job carries
contract: nullalongside anerrorobject. Foundry requiredcontractto be an object, so it retried a permanent deserialization failure and hid the verifier's actual RPC rate-limit error.This models the contract result as optional, allowing the existing terminal-error path to report the verifier code and message immediately. Regression coverage exercises the full status-polling path with a null-contract error response.
This PR was prepared with AI assistance.